Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Remove linguist-generated git attribute from test snapshot data/fixtures #75194

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 22, 2025

Based on the results of this poll: https://vercel.slack.com/archives/C04KC8A53T7/p1734380259031279

In my experience these fixtures need to be carefully reviewed, same as the code that changed them. Collapsing them by default will make this more difficult and possibly error-prone.

Closes PACK-3789

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 22, 2025
Copy link
Member Author

bgw commented Jan 22, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bgw bgw marked this pull request as ready for review January 22, 2025 17:56
@ijjk
Copy link
Member

ijjk commented Jan 22, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/remove-linguist-generated-tests Change
buildDuration 19.6s 17.5s N/A
buildDurationCached 16.6s 14s N/A
nodeModulesSize 419 MB 419 MB N/A
nextStartRea..uration (ms) 429ms 443ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/remove-linguist-generated-tests Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.6 kB 34.6 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/remove-linguist-generated-tests Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js bgw/remove-linguist-generated-tests Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/remove-linguist-generated-tests Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/remove-linguist-generated-tests Change
index.html gzip 524 B 523 B N/A
link.html gzip 540 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/remove-linguist-generated-tests Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 209 kB 209 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js bgw/remove-linguist-generated-tests Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js bgw/remove-linguist-generated-tests Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 376 kB 376 kB
app-page-exp..prod.js gzip 131 kB 131 kB
app-page-tur..prod.js gzip 144 kB 144 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 364 kB 364 kB
app-page.run..prod.js gzip 127 kB 127 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.48 MB 2.48 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/remove-linguist-generated-tests Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +2.67 kB
index.pack gzip 75.7 kB 74.7 kB N/A
Overall change 2.1 MB 2.1 MB ⚠️ +2.67 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: cdeefe5

@bgw bgw merged commit ba32dfe into canary Jan 22, 2025
132 checks passed
Copy link
Member Author

bgw commented Jan 22, 2025

Merge activity

  • Jan 22, 1:21 PM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/remove-linguist-generated-tests branch January 22, 2025 18:21
@github-actions github-actions bot added the locked label Feb 6, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants