From c877e4de2684b4f4985531d555b87e6c979486cb Mon Sep 17 00:00:00 2001 From: Jude Gao Date: Tue, 21 Jan 2025 14:58:07 -0500 Subject: [PATCH] clean unused stop --- .../next/src/server/dev/hot-reloader-turbopack.ts | 3 --- .../next/src/server/dev/hot-reloader-types.ts | 1 - .../next/src/server/dev/hot-reloader-webpack.ts | 15 --------------- 3 files changed, 19 deletions(-) diff --git a/packages/next/src/server/dev/hot-reloader-turbopack.ts b/packages/next/src/server/dev/hot-reloader-turbopack.ts index d710bf8994a27..47af297218d72 100644 --- a/packages/next/src/server/dev/hot-reloader-turbopack.ts +++ b/packages/next/src/server/dev/hot-reloader-turbopack.ts @@ -850,9 +850,6 @@ export async function createHotReloaderTurbopack( // Not implemented yet. }, async start() {}, - async stop() { - // Not implemented yet. - }, async getCompilationErrors(page) { const appEntryKey = getEntryKey('app', 'server', page) const pagesEntryKey = getEntryKey('pages', 'server', page) diff --git a/packages/next/src/server/dev/hot-reloader-types.ts b/packages/next/src/server/dev/hot-reloader-types.ts index 58f0a0c297859..f7e014f331e96 100644 --- a/packages/next/src/server/dev/hot-reloader-types.ts +++ b/packages/next/src/server/dev/hot-reloader-types.ts @@ -153,7 +153,6 @@ export interface NextJsHotReloaderInterface { setHmrServerError(error: Error | null): void clearHmrServerError(): void start(): Promise - stop(): Promise send(action: HMR_ACTION_TYPES): void getCompilationErrors(page: string): Promise onHMR( diff --git a/packages/next/src/server/dev/hot-reloader-webpack.ts b/packages/next/src/server/dev/hot-reloader-webpack.ts index e71ea8a6165ff..2d0a27a485a7c 100644 --- a/packages/next/src/server/dev/hot-reloader-webpack.ts +++ b/packages/next/src/server/dev/hot-reloader-webpack.ts @@ -1525,21 +1525,6 @@ export default class HotReloaderWebpack implements NextJsHotReloaderInterface { } } - public async stop(): Promise { - await new Promise((resolve, reject) => { - this.watcher.close((err: any) => (err ? reject(err) : resolve(true))) - }) - - if (this.fallbackWatcher) { - await new Promise((resolve, reject) => { - this.fallbackWatcher.close((err: any) => - err ? reject(err) : resolve(true) - ) - }) - } - this.multiCompiler = undefined - } - public async getCompilationErrors(page: string) { const getErrors = ({ compilation }: webpack.Stats) => { const failedPages = erroredPages(compilation)