Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hostname to default error boundary message #75151

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Jan 21, 2025

Since it's possible to deploy an application that triggers our default exception handling, we should ensure the error text is personalized to the host application to avoid any potential incorrect canonicalization by search engines for containing duplicate content.

slack context

Copy link
Member Author

ztanner commented Jan 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Jan 21, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 21, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-21-add_hostname_to_default_error_boundary Change
buildDuration 18.2s 16.1s N/A
buildDurationCached 15.3s 13.1s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +10.2 kB
nextStartRea..uration (ms) 428ms 410ms N/A
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-21-add_hostname_to_default_error_boundary Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 239 B 242 B N/A
main-HASH.js gzip 34.4 kB 34.6 kB ⚠️ +163 B
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 87.3 kB 87.5 kB ⚠️ +163 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-21-add_hostname_to_default_error_boundary Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-21-add_hostname_to_default_error_boundary Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-21-add_hostname_to_default_error_boundary Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-21-add_hostname_to_default_error_boundary Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 539 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-21-add_hostname_to_default_error_boundary Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-21-add_hostname_to_default_error_boundary Change
middleware-b..fest.js gzip 668 B 663 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 01-21-add_hostname_to_default_error_boundary Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 375 kB 375 kB N/A
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 363 kB 363 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.1 MB 2.1 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-21-add_hostname_to_default_error_boundary Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +3.14 kB
index.pack gzip 75.9 kB 75.6 kB N/A
Overall change 2.1 MB 2.1 MB ⚠️ +3.14 kB
Diff details
Diff for edge-ssr.js

Diff too large to display

Diff for 5306-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: 1aeec48

@ztanner ztanner force-pushed the 01-21-add_hostname_to_default_error_boundary branch from af70ac9 to 1aeec48 Compare January 21, 2025 20:06
@ztanner ztanner marked this pull request as ready for review January 21, 2025 21:32
@ztanner ztanner requested review from huozhi and ijjk January 21, 2025 21:32
@ztanner ztanner merged commit f872b6d into canary Jan 22, 2025
133 checks passed
@ztanner ztanner deleted the 01-21-add_hostname_to_default_error_boundary branch January 22, 2025 00:05
@github-actions github-actions bot added the locked label Feb 5, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants