Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] pass sourceMap flag to webpack loaders and postcss #75144

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 21, 2025

What?

  • pass sourceMap flag to webpack loaders
  • run postcss transform without SourceMaps when specified

Closes PACK-3781

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 21, 2025
Copy link
Member Author

sokra commented Jan 21, 2025

@sokra sokra changed the title pass sourceMap flag to webpack loaders [Turbopack] pass sourceMap flag to webpack loaders Jan 21, 2025
@sokra sokra changed the title [Turbopack] pass sourceMap flag to webpack loaders [Turbopack] pass sourceMap flag to webpack loaders and postcss Jan 21, 2025
@sokra sokra requested a review from mischnic January 21, 2025 15:32
@sokra sokra marked this pull request as ready for review January 21, 2025 15:32
@ijjk
Copy link
Member

ijjk commented Jan 21, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 21, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/source-maps-transforms Change
buildDuration 18s 16.4s N/A
buildDurationCached 15.4s 13.3s N/A
nodeModulesSize 418 MB 418 MB N/A
nextStartRea..uration (ms) 427ms 425ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/source-maps-transforms Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/source-maps-transforms Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/source-maps-transforms Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/source-maps-transforms Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/source-maps-transforms Change
index.html gzip 523 B 523 B
link.html gzip 538 B 538 B
withRouter.html gzip 519 B 520 B N/A
Overall change 1.06 kB 1.06 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/source-maps-transforms Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/source-maps-transforms Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/source-maps-transforms Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 375 kB 375 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 363 kB 363 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.47 MB 2.47 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/source-maps-transforms Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 74.7 kB 75.2 kB ⚠️ +482 B
Overall change 74.7 kB 75.2 kB ⚠️ +482 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 2361f98

@sokra sokra force-pushed the sokra/source-maps-transforms branch from 03873fd to 9000d0c Compare January 21, 2025 20:54
@sokra sokra changed the base branch from sokra/allow-disable-source-maps to graphite-base/75144 January 21, 2025 22:00
@sokra sokra force-pushed the sokra/source-maps-transforms branch from 9000d0c to 870733f Compare January 21, 2025 22:01
@sokra sokra force-pushed the graphite-base/75144 branch from 3eb0cf5 to 59c5e2f Compare January 21, 2025 22:01
@sokra sokra changed the base branch from graphite-base/75144 to canary January 21, 2025 22:01
@sokra sokra force-pushed the sokra/source-maps-transforms branch from 870733f to 2361f98 Compare January 21, 2025 22:02
@sokra sokra merged commit d4d78b5 into canary Jan 21, 2025
131 checks passed
Copy link
Member Author

sokra commented Jan 21, 2025

Merge activity

  • Jan 21, 5:52 PM EST: A user merged this pull request with Graphite.

@sokra sokra deleted the sokra/source-maps-transforms branch January 21, 2025 22:52
@github-actions github-actions bot added the locked label Feb 5, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants