Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CI runner labels in Turborepo hashes #75099

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

unstubbable
Copy link
Contributor

@unstubbable unstubbable commented Jan 20, 2025

Avoids cache collisions for output with platform-specific contents (e.g. paths) that may be generated on Linux or Windows runners. Docs: https://turbo.build/repo/docs/crafting-your-repository/using-environment-variables#adding-environment-variables-to-task-hashes

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jan 20, 2025
@ijjk
Copy link
Member

ijjk commented Jan 20, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js hl/fix-turborepo-cache Change
buildDuration 18.6s 15.6s N/A
buildDurationCached 14.6s 12.4s N/A
nodeModulesSize 418 MB 418 MB
nextStartRea..uration (ms) 419ms 397ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hl/fix-turborepo-cache Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hl/fix-turborepo-cache Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js hl/fix-turborepo-cache Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js hl/fix-turborepo-cache Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js hl/fix-turborepo-cache Change
index.html gzip 524 B 524 B
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hl/fix-turborepo-cache Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js hl/fix-turborepo-cache Change
middleware-b..fest.js gzip 671 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js hl/fix-turborepo-cache Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 375 kB 375 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 363 kB 363 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.47 MB 2.47 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js hl/fix-turborepo-cache Change
0.pack gzip 2.09 MB 2.1 MB ⚠️ +783 B
index.pack gzip 76.1 kB 75.9 kB N/A
Overall change 2.09 MB 2.1 MB ⚠️ +783 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: a35692a

@unstubbable unstubbable marked this pull request as ready for review January 20, 2025 11:58
@ijjk
Copy link
Member

ijjk commented Jan 20, 2025

Failing test suites

Commit: a35692a

pnpm test-start-turbo test/production/deployment-id-handling/deployment-id-handling.test.ts (turbopack)

  • deployment-id-handling enabled with NEXT_DEPLOYMENT_ID > should contain deployment id in RSC payload request headers
Expand output

● deployment-id-handling enabled with NEXT_DEPLOYMENT_ID › should contain deployment id in RSC payload request headers

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#other-app')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as waitForElementByCss] (lib/browsers/playwright.ts:423:17)
  at BrowserInterface.waitForElementByCss [as elementByCss] (lib/browsers/playwright.ts:343:17)
  at Object.elementByCss (production/deployment-id-handling/deployment-id-handling.test.ts:128:21)
  at Proxy.chain (lib/browsers/base.ts:17:23)
  at Proxy.chain (lib/browsers/playwright.ts:395:17)
  at Object.click (production/deployment-id-handling/deployment-id-handling.test.ts:128:48)

Read more about building and testing Next.js in contributing.md.

@unstubbable
Copy link
Contributor Author

unstubbable commented Jan 20, 2025

Seems to work generally. The test deployment-id-handling disabled fails consistently, which appears to be unrelated. So I'm merging anyways to unblock other PRs.

@unstubbable unstubbable merged commit 6d17cc6 into canary Jan 20, 2025
128 of 130 checks passed
@unstubbable unstubbable deleted the hl/fix-turborepo-cache branch January 20, 2025 12:26
@github-actions github-actions bot added the locked label Feb 4, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants