Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Turbopack] try to avoid too small chunks size when optimizing for production #75048

Merged
merged 4 commits into from
Jan 20, 2025
Merged

[Turbopack] try to avoid too small chunks size when optimizing for production #75048

merged 4 commits into from
Jan 20, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 17, 2025 •
edited by padmaia
Loading

What?

Merge small chunks if they are below the min chunk size of 20kb

Closes PACK-3770

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 17, 2025
This was referenced Jan 17, 2025
Merged
Merged
Merged
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra mentioned this pull request Jan 17, 2025
Draft
@ijjk
Copy link
Member

ijjk commented Jan 17, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/smarter-production-chunking Change
buildDuration 18s 15.1s N/A
buildDurationCached 14.3s 11.9s N/A
nodeModulesSize 418 MB 418 MB ✓
nextStartRea..uration (ms) 416ms 421ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/smarter-production-chunking Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB ✓
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 241 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/smarter-production-chunking Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sokra/smarter-production-chunking Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/smarter-production-chunking Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/smarter-production-chunking Change
index.html gzip 524 B 524 B ✓
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 1.04 kB 1.04 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/smarter-production-chunking Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sokra/smarter-production-chunking Change
middleware-b..fest.js gzip 671 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js sokra/smarter-production-chunking Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 375 kB 375 kB ✓
app-page-exp..prod.js gzip 130 kB 130 kB ✓
app-page-tur..prod.js gzip 143 kB 143 kB ✓
app-page-tur..prod.js gzip 139 kB 139 kB ✓
app-page.run...dev.js gzip 363 kB 363 kB ✓
app-page.run..prod.js gzip 126 kB 126 kB ✓
app-route-ex...dev.js gzip 37.6 kB 37.6 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 27.7 kB 27.7 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.47 MB 2.47 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/smarter-production-chunking Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +1.6 kB
index.pack gzip 74.4 kB 75.2 kB ⚠️ +724 B
Overall change 2.17 MB 2.17 MB ⚠️ +2.33 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 682eef3

@sokra sokra requested a review from wbinnssmith January 17, 2025 20:39
@sokra sokra added the CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci label Jan 17, 2025 — with Graphite App
@sokra sokra changed the title try to avoid too small chunks size when optimizing for production [Turbopack] try to avoid too small chunks size when optimizing for production Jan 17, 2025
@sokra sokra force-pushed the sokra/smarter-production-chunking branch from 05242ad to 82b22dc Compare January 17, 2025 20:46
@ijjk
Copy link
Member

ijjk commented Jan 17, 2025 •
edited
Loading

Tests Passed

@sokra sokra mentioned this pull request Jan 17, 2025
Merged
@sokra sokra marked this pull request as ready for review January 17, 2025 23:58
@sokra sokra changed the base branch from sokra/production-chunking to graphite-base/75048 January 20, 2025 08:53
@sokra sokra force-pushed the graphite-base/75048 branch from 722d4f0 to 169829a Compare January 20, 2025 08:54
@sokra sokra force-pushed the sokra/smarter-production-chunking branch from 192e36a to e6b3f02 Compare January 20, 2025 08:54
@sokra sokra changed the base branch from graphite-base/75048 to canary January 20, 2025 08:54
@sokra sokra force-pushed the sokra/smarter-production-chunking branch from e6b3f02 to 718dcfc Compare January 20, 2025 08:54
@mischnic mischnic force-pushed the sokra/smarter-production-chunking branch from c6cdfc7 to 682eef3 Compare January 20, 2025 12:27
@sokra sokra merged commit 351fdbc into canary Jan 20, 2025
131 checks passed
@sokra sokra deleted the sokra/smarter-production-chunking branch January 20, 2025 13:17
@github-actions github-actions bot added the locked label Feb 4, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mischnic mischnic mischnic approved these changes

@wbinnssmith wbinnssmith Awaiting requested review from wbinnssmith

Assignees
No one assigned
Labels
CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @ijjk @mischnic