Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOverlay] Open Error Overlay when DevTools Indicator clicked #75025

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 17, 2025

Open the Error Overlay when DevTools Indicator is clicked to preserve the one-click away from the overlay UX.

Before

CleanShot.2025-01-17.at.18.17.52.mp4

After

CleanShot.2025-01-17.at.18.04.43.mp4

Closes NDX-685

@ijjk
Copy link
Member

ijjk commented Jan 17, 2025

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked Change
buildDuration 20.6s 18.9s N/A
buildDurationCached 17.8s 15.2s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +3.47 kB
nextStartRea..uration (ms) 475ms 482ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 239 B 242 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked Change
index.html gzip 523 B 523 B
link.html gzip 538 B 537 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked Change
middleware-b..fest.js gzip 671 B 665 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 374 kB 374 kB N/A
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 362 kB 362 kB N/A
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.74 MB 1.74 MB
build cache
vercel/next.js canary vercel/next.js 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 75.2 kB 74 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: e207dfa

@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 17, 2025 09:20
@devjiwonchoi devjiwonchoi force-pushed the 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked branch from 5820d4d to 39be163 Compare January 17, 2025 09:21
@devjiwonchoi devjiwonchoi force-pushed the 01-17-_devoverlay_decouple_error_overlay_with_devtools_indicator branch from ede3650 to c6df338 Compare January 18, 2025 09:43
@devjiwonchoi devjiwonchoi force-pushed the 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked branch from 39be163 to 389141e Compare January 18, 2025 09:44
@devjiwonchoi devjiwonchoi force-pushed the 01-17-_devoverlay_decouple_error_overlay_with_devtools_indicator branch from c6df338 to d7209b6 Compare January 18, 2025 11:25
@devjiwonchoi devjiwonchoi force-pushed the 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked branch 3 times, most recently from 2004aad to 0140873 Compare January 20, 2025 13:10
@devjiwonchoi devjiwonchoi force-pushed the 01-17-_devoverlay_decouple_error_overlay_with_devtools_indicator branch from 5c4368e to 13dbcea Compare January 20, 2025 18:36
@devjiwonchoi devjiwonchoi force-pushed the 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked branch from 0140873 to 19d58d6 Compare January 20, 2025 18:36
Copy link
Member Author

devjiwonchoi commented Jan 21, 2025

Merge activity

  • Jan 20, 11:00 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 20, 11:02 PM EST: Graphite couldn't merge this PR because it had conflicts with the trunk branch.
  • Jan 21, 12:02 AM EST: A user merged this pull request with Graphite.

@devjiwonchoi devjiwonchoi changed the base branch from 01-17-_devoverlay_decouple_error_overlay_with_devtools_indicator to graphite-base/75025 January 21, 2025 04:01
@devjiwonchoi devjiwonchoi changed the base branch from graphite-base/75025 to canary January 21, 2025 04:01
@devjiwonchoi devjiwonchoi force-pushed the 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked branch from 19d58d6 to 7bcd007 Compare January 21, 2025 04:07
@devjiwonchoi devjiwonchoi merged commit dbd5e1b into canary Jan 21, 2025
133 checks passed
@devjiwonchoi devjiwonchoi deleted the 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked branch January 21, 2025 05:02
@github-actions github-actions bot added the locked label Feb 6, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants