Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(turbopack): Reduce size of EffectArg #74973

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 16, 2025

Closes PACK-3771

@kdy1 kdy1 marked this pull request as ready for review January 16, 2025 07:58
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-size branch from 5e22be0 to 41a9221 Compare January 16, 2025 09:14
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-arg-size branch from af00060 to f8def63 Compare January 16, 2025 09:15
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-size branch from 41a9221 to 33e1a32 Compare January 16, 2025 09:27
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-arg-size branch from f8def63 to fdd9c74 Compare January 16, 2025 09:27
@ijjk
Copy link
Member

ijjk commented Jan 16, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-effect-arg-size Change
buildDuration 17.3s 15.7s N/A
buildDurationCached 14.8s 12.6s N/A
nodeModulesSize 418 MB 418 MB N/A
nextStartRea..uration (ms) 402ms 400ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-effect-arg-size Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-effect-arg-size Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-effect-arg-size Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-effect-arg-size Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-effect-arg-size Change
index.html gzip 524 B 524 B
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-effect-arg-size Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-effect-arg-size Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-effect-arg-size Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 375 kB 375 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 363 kB 363 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.47 MB 2.47 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-effect-arg-size Change
0.pack gzip 2.1 MB 2.09 MB N/A
index.pack gzip 74.8 kB 75.6 kB ⚠️ +799 B
Overall change 74.8 kB 75.6 kB ⚠️ +799 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 2e9d813

@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-size branch from 33e1a32 to 723f0bc Compare January 16, 2025 11:00
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-arg-size branch from fdd9c74 to 72fe63c Compare January 16, 2025 11:01
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-size branch from 723f0bc to 3e0fddc Compare January 16, 2025 12:30
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-arg-size branch from 72fe63c to 9e5fd63 Compare January 16, 2025 12:30
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-size branch 2 times, most recently from c5cbcb0 to 5542464 Compare January 16, 2025 13:38
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-arg-size branch from 9e5fd63 to b786be9 Compare January 16, 2025 13:38
@kdy1 kdy1 changed the base branch from kdy1/dod-es-analyzer-effect-size to graphite-base/74973 January 16, 2025 14:04
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-arg-size branch from b786be9 to d450cf9 Compare January 16, 2025 14:04
@kdy1 kdy1 force-pushed the graphite-base/74973 branch from 5542464 to 5c2a39f Compare January 16, 2025 14:04
@kdy1 kdy1 changed the base branch from graphite-base/74973 to canary January 16, 2025 14:05
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-arg-size branch 2 times, most recently from 80ea061 to 4402f88 Compare January 17, 2025 04:45
@ijjk
Copy link
Member

ijjk commented Jan 17, 2025

Tests Passed

@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-arg-size branch from 4402f88 to 759e613 Compare January 20, 2025 11:59
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-effect-arg-size branch from 759e613 to 2e9d813 Compare January 20, 2025 12:47
@kdy1 kdy1 requested review from sokra and a team and removed request for sokra January 20, 2025 13:10
@kdy1 kdy1 merged commit 534cf16 into canary Jan 20, 2025
133 checks passed
Copy link
Member Author

kdy1 commented Jan 20, 2025

Merge activity

  • Jan 20, 10:49 PM GMT+9: A user merged this pull request with Graphite.

@kdy1 kdy1 deleted the kdy1/dod-es-analyzer-effect-arg-size branch January 20, 2025 13:50
@github-actions github-actions bot added the locked label Feb 4, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2025
@kdy1 kdy1 self-assigned this Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants