Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(turbopack): Merge Atom and JsWord variant of ConstantString #74967

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 16, 2025

What?

Merge two variants as those are exactly the same.

Why?

JsWord is an alias of Atom.

Closes PACK-3745

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 16, 2025
@kdy1 kdy1 changed the title refactor(turbopack): Atom and JsWord is same type refactor(turbopack): Merge Atom and JsWord variant of Jan 16, 2025
@kdy1 kdy1 changed the title refactor(turbopack): Merge Atom and JsWord variant of refactor(turbopack): Merge Atom and JsWord variant of ConstantString Jan 16, 2025
@kdy1 kdy1 marked this pull request as ready for review January 16, 2025 06:37
@ijjk
Copy link
Member

ijjk commented Jan 16, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-merge-atom-jsword Change
buildDuration 17.3s 15.2s N/A
buildDurationCached 14.4s 11.9s N/A
nodeModulesSize 418 MB 418 MB N/A
nextStartRea..uration (ms) 415ms 427ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-merge-atom-jsword Change
5306-HASH.js gzip 53.9 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-merge-atom-jsword Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-merge-atom-jsword Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-merge-atom-jsword Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-merge-atom-jsword Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-merge-atom-jsword Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-merge-atom-jsword Change
middleware-b..fest.js gzip 673 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-merge-atom-jsword Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 374 kB 374 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 362 kB 362 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.47 MB 2.47 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/dod-es-analyzer-merge-atom-jsword Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 74.2 kB 75.2 kB ⚠️ +977 B
Overall change 74.2 kB 75.2 kB ⚠️ +977 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 77879a5

@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-bigint branch from f2523c6 to 0cdb3e5 Compare January 16, 2025 07:23
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-merge-atom-jsword branch from b95927c to 1b55219 Compare January 16, 2025 07:23
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-bigint branch 2 times, most recently from ea02ae0 to a0c4085 Compare January 16, 2025 07:40
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-merge-atom-jsword branch 2 times, most recently from 3db1c39 to 3f3f8ca Compare January 16, 2025 07:48
@kdy1 kdy1 changed the base branch from kdy1/dod-es-analyzer-bigint to graphite-base/74967 January 16, 2025 09:13
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-merge-atom-jsword branch from 3f3f8ca to 2552b6c Compare January 16, 2025 09:13
@kdy1 kdy1 force-pushed the graphite-base/74967 branch from a0c4085 to 53b5dc6 Compare January 16, 2025 09:13
@kdy1 kdy1 changed the base branch from graphite-base/74967 to canary January 16, 2025 09:14
@kdy1 kdy1 force-pushed the kdy1/dod-es-analyzer-merge-atom-jsword branch from 2552b6c to 1ec7139 Compare January 16, 2025 09:14
@ijjk
Copy link
Member

ijjk commented Jan 16, 2025

Tests Passed

@kdy1 kdy1 merged commit 0cfa5f4 into canary Jan 16, 2025
131 checks passed
Copy link
Member Author

kdy1 commented Jan 16, 2025

Merge activity

  • Jan 16, 7:59 PM GMT+9: A user merged this pull request with Graphite.

@kdy1 kdy1 deleted the kdy1/dod-es-analyzer-merge-atom-jsword branch January 16, 2025 10:59
@github-actions github-actions bot added the locked label Feb 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
@kdy1 kdy1 self-assigned this Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants