fix: moved down segment path handling after cache headers are set

[wyattjoh]

Previously, the segment path handling was returning before the x-nextjs-cache headers were sent, this moves it below that to ensure that the correct cache headers are added.

[wyattjoh]

• fix: moved down segment path handling after cache headers are set #74893 👈 (View in Graphite)
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ijjk]

Failing test suites

Commit: 8c3e4b2

pnpm test-dev-turbo test/development/acceptance/ReactRefreshRequire.test.ts (turbopack)

• ReactRefreshRequire > propagates a hot update to closest accepted module
• ReactRefreshRequire > propagates a module that stops accepting in next version

Expand output

● ReactRefreshRequire › propagates a hot update to closest accepted module

expect(received).toEqual(expected) // deep equality

Expected: ["init FooV1", "init BarV1"]
Received: undefined

   95 |     )
   96 |
>  97 |     expect(await session.evaluate(() => (window as any).log)).toEqual([
      |                                                               ^
   98 |       'init FooV1',
   99 |       'init BarV1',
  100 |     ])

  at Object.toEqual (development/acceptance/ReactRefreshRequire.test.ts:97:63)

● ReactRefreshRequire › propagates a module that stops accepting in next version

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

  Array [
    "init BarV2",
    "init FooV1",
+   "init BarV2",
  ]

  440 |     // Since the export list changed, we have to re-run both the parent
  441 |     // and the child.
> 442 |     expect(await session.evaluate(() => (window as any).log)).toEqual([
      |                                                               ^
  443 |       'init BarV2',
  444 |       'init FooV1',
  445 |     ])

  at Object.toEqual (development/acceptance/ReactRefreshRequire.test.ts:442:63)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build

General

	vercel/next.js canary	vercel/next.js fix/segment-path-cache-headers	Change
buildDuration	16.4s	15s	N/A
buildDurationCached	14s	11.7s	N/A
nodeModulesSize	418 MB	418 MB	N/A
nextStartRea..uration (ms)	403ms	407ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js fix/segment-path-cache-headers	Change
5306-HASH.js gzip	53.9 kB	53.9 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.44 kB	5.44 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	34.2 kB	34.2 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js fix/segment-path-cache-headers	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js fix/segment-path-cache-headers	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.57 kB	4.57 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js fix/segment-path-cache-headers	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js fix/segment-path-cache-headers	Change
index.html gzip	524 B	524 B	✓
link.html gzip	539 B	538 B	N/A
withRouter.html gzip	520 B	520 B	✓
Overall change	1.04 kB	1.04 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js fix/segment-path-cache-headers	Change
edge-ssr.js gzip	129 kB	129 kB	N/A
page.js gzip	208 kB	208 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js fix/segment-path-cache-headers	Change
middleware-b..fest.js gzip	668 B	668 B	✓
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	1.51 kB	1.51 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js fix/segment-path-cache-headers	Change
274-experime...dev.js gzip	322 B	322 B	✓
274.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	374 kB	374 kB	✓
app-page-exp..prod.js gzip	130 kB	130 kB	✓
app-page-tur..prod.js gzip	143 kB	143 kB	✓
app-page-tur..prod.js gzip	139 kB	139 kB	✓
app-page.run...dev.js gzip	362 kB	362 kB	✓
app-page.run..prod.js gzip	126 kB	126 kB	✓
app-route-ex...dev.js gzip	37.6 kB	37.6 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	39.2 kB	39.2 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.7 kB	21.7 kB	✓
pages.runtim...dev.js gzip	27.5 kB	27.5 kB	✓
pages.runtim..prod.js gzip	21.7 kB	21.7 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	N/A
Overall change	1.55 MB	1.55 MB	✓

build cache

	vercel/next.js canary	vercel/next.js fix/segment-path-cache-headers	Change
0.pack gzip	2.1 MB	2.09 MB	N/A
index.pack gzip	75.1 kB	75.1 kB	N/A
Overall change	0 B	0 B	✓

Diff details

Diff for edge-ssr.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 8c3e4b2