Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: write the segment path data out from the incremental cache #74892

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

wyattjoh
Copy link
Member

@wyattjoh wyattjoh commented Jan 15, 2025

This writes out the segment path information when the incremental cache writes to disk. This also combines the multi-file writer approach used in a few places into a single shared utility class.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 15, 2025
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wyattjoh wyattjoh marked this pull request as ready for review January 15, 2025 00:38
@ijjk
Copy link
Member

ijjk commented Jan 15, 2025

Tests Passed

@wyattjoh wyattjoh requested a review from ijjk January 15, 2025 00:41
@wyattjoh wyattjoh force-pushed the feat/incremental-segment-paths branch from 89784e3 to 9b4bc32 Compare January 15, 2025 00:43
@ijjk
Copy link
Member

ijjk commented Jan 15, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/incremental-segment-paths Change
buildDuration 23.2s 15.2s N/A
buildDurationCached 14.3s 12.2s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +33.8 kB
nextStartRea..uration (ms) 418ms 425ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js feat/incremental-segment-paths Change
5306-HASH.js gzip 53.9 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 241 B
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 241 B 241 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/incremental-segment-paths Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js feat/incremental-segment-paths Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feat/incremental-segment-paths Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feat/incremental-segment-paths Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/incremental-segment-paths Change
edge-ssr.js gzip 129 kB 129 kB ⚠️ +202 B
page.js gzip 208 kB 208 kB ⚠️ +183 B
Overall change 337 kB 337 kB ⚠️ +385 B
Middleware size
vercel/next.js canary vercel/next.js feat/incremental-segment-paths Change
middleware-b..fest.js gzip 670 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/incremental-segment-paths Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 374 kB 374 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 362 kB 362 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB ⚠️ +180 B
Overall change 2.47 MB 2.47 MB ⚠️ +180 B
build cache
vercel/next.js canary vercel/next.js feat/incremental-segment-paths Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 74.3 kB 74.3 kB N/A
Overall change 0 B 0 B
Diff details
Diff for edge-ssr.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: c57fd50

@wyattjoh wyattjoh force-pushed the feat/incremental-segment-paths branch from 9b4bc32 to c57fd50 Compare January 15, 2025 18:52
@wyattjoh wyattjoh merged commit b44035d into canary Jan 15, 2025
131 checks passed
@wyattjoh wyattjoh deleted the feat/incremental-segment-paths branch January 15, 2025 19:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants