docs update: Remove public access modifier from resetRequestCache method in CacheHandler class, it's not available in js file (only in typescript) #74788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod in CacheHandler class, it's not available in js file (only in typescript)
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
gaojude
approved these changes
Jan 11, 2025
ijjk
approved these changes
Jan 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
During development I noticed that example of custom CacheHandler contains expression that works only in TypeScript but the file is declared as JS.
Why?
To improve documentation DX, so other developers won't be surprised that code they copied from official docs is not correct semantically.
How?
Added small fix removing public accessor