Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination SEO link tags #74737

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

Zach-Jaensch
Copy link
Contributor

@Zach-Jaensch Zach-Jaensch commented Jan 10, 2025

Apologies in advance if I have missed something in the contributing process.

Fixes #52925

What?

Adds metadata config option for pagination link tags.

Why?

The <link rel="prev" and <link rel="next" are used by search crawlers and can help with SEO performance.
For more information: https://developers.google.com/search/blog/2011/09/pagination-with-relnext-and-relprev

How?

Uses existing patterns for metadata config.

@Zach-Jaensch Zach-Jaensch marked this pull request as ready for review January 10, 2025 09:21
@huozhi huozhi added the CI approved Approve running CI for fork label Jan 13, 2025
@ijjk
Copy link
Member

ijjk commented Jan 13, 2025

Failing test suites

Commit: c134468

pnpm test test/integration/app-dir-export/test/start.test.ts

  • app dir - with output export (next start) > production mode > should warn during next start with output standalone
Expand output

● app dir - with output export (next start) › production mode › should warn during next start with output standalone

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  46 |
  47 |       // TODO: Move this test to test/production to run in isolation.
> 48 |       ;(process.env.TURBOPACK_BUILD ? it.skip : it)(
     |                                                  ^
  49 |         'should warn during next start with output standalone',
  50 |         async () => {
  51 |           nextConfig.replace(`output: 'export'`, `output: 'standalone'`)

  at integration/app-dir-export/test/start.test.ts:48:50
  at integration/app-dir-export/test/start.test.ts:21:56
  at Object.describe (integration/app-dir-export/test/start.test.ts:20:1)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Jan 13, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Zach-Jaensch/next.js pagination_seo Change
buildDuration 23s 20.9s N/A
buildDurationCached 19.9s 17.3s N/A
nodeModulesSize 417 MB 417 MB ⚠️ +14.4 kB
nextStartRea..uration (ms) 550ms 546ms N/A
Client Bundles (main, webpack)
vercel/next.js canary Zach-Jaensch/next.js pagination_seo Change
5306-HASH.js gzip 53.3 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Zach-Jaensch/next.js pagination_seo Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary Zach-Jaensch/next.js pagination_seo Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary Zach-Jaensch/next.js pagination_seo Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary Zach-Jaensch/next.js pagination_seo Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary Zach-Jaensch/next.js pagination_seo Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary Zach-Jaensch/next.js pagination_seo Change
middleware-b..fest.js gzip 671 B 671 B
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 1.51 kB 1.51 kB
Next Runtimes
vercel/next.js canary Zach-Jaensch/next.js pagination_seo Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 369 kB 369 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 357 kB 357 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.46 MB 2.46 MB
build cache Overall increase ⚠️
vercel/next.js canary Zach-Jaensch/next.js pagination_seo Change
0.pack gzip 2.09 MB 2.09 MB ⚠️ +207 B
index.pack gzip 73.7 kB 74 kB ⚠️ +310 B
Overall change 2.17 MB 2.17 MB ⚠️ +517 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: c134468

Copy link
Member

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@huozhi huozhi merged commit 15915c3 into vercel:canary Jan 14, 2025
101 of 103 checks passed
@Zach-Jaensch Zach-Jaensch deleted the pagination_seo branch January 15, 2025 04:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: link tag with rel="next" and rel="prev"
3 participants