Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DevToolsIndicator #74679

Merged

Conversation

gaojude
Copy link
Contributor

@gaojude gaojude commented Jan 9, 2025

Adding a DevToolsIndicator to the bottom left corner of the screen, replacing the old ErrorIndicator and StaticIndicator. This PR brings us 80% of the way to our goal. The remaining tasks are marked with TODOs.

CleanShot.2025-01-09.at.08.37.28.mp4

@gaojude gaojude changed the title consolidate static route to dev tools indicator refactor: consolidate static route to dev tools indicator Jan 9, 2025
Copy link
Contributor Author

gaojude commented Jan 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gaojude gaojude marked this pull request as ready for review January 9, 2025 02:19
@ijjk
Copy link
Member

ijjk commented Jan 9, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-08-consolidate_static_route_to_dev_tools_indicator Change
buildDuration 19.5s 16.5s N/A
buildDurationCached 15.6s 13.1s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +287 kB
nextStartRea..uration (ms) 461ms 461ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-08-consolidate_static_route_to_dev_tools_indicator Change
5306-HASH.js gzip 53.4 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-08-consolidate_static_route_to_dev_tools_indicator Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-08-consolidate_static_route_to_dev_tools_indicator Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-08-consolidate_static_route_to_dev_tools_indicator Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-08-consolidate_static_route_to_dev_tools_indicator Change
index.html gzip 523 B 523 B
link.html gzip 538 B 537 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-08-consolidate_static_route_to_dev_tools_indicator Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-08-consolidate_static_route_to_dev_tools_indicator Change
middleware-b..fest.js gzip 669 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-08-consolidate_static_route_to_dev_tools_indicator Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 365 kB 367 kB ⚠️ +1.75 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 354 kB 355 kB ⚠️ +1.72 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.45 MB 2.46 MB ⚠️ +3.47 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-08-consolidate_static_route_to_dev_tools_indicator Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 74.3 kB 74.8 kB ⚠️ +482 B
Overall change 74.3 kB 74.8 kB ⚠️ +482 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: c49193f

@ijjk
Copy link
Member

ijjk commented Jan 9, 2025

Tests Passed

@gaojude gaojude force-pushed the 01-08-consolidate_static_route_to_dev_tools_indicator branch from 1b8ec36 to e5e62b8 Compare January 9, 2025 02:26
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 9, 2025
@gaojude gaojude changed the title refactor: consolidate static route to dev tools indicator feat: DevToolsIndicator scaffolding & deprecating StaticIndicator Jan 9, 2025
@gaojude gaojude force-pushed the 01-08-consolidate_static_route_to_dev_tools_indicator branch from e5e62b8 to 384a7ab Compare January 9, 2025 02:33
@gaojude gaojude requested a review from devjiwonchoi January 9, 2025 02:34
@gaojude gaojude changed the title feat: DevToolsIndicator scaffolding & deprecating StaticIndicator feat: DevToolsIndicator Jan 9, 2025
@gaojude gaojude force-pushed the 01-08-consolidate_static_route_to_dev_tools_indicator branch 3 times, most recently from 1e087ff to 20dd0c3 Compare January 9, 2025 13:51
@gaojude gaojude force-pushed the 01-08-consolidate_static_route_to_dev_tools_indicator branch 2 times, most recently from 23f6fd4 to 1f6e10c Compare January 9, 2025 15:48
@gaojude gaojude force-pushed the 01-08-consolidate_static_route_to_dev_tools_indicator branch from 1f6e10c to c49193f Compare January 9, 2025 16:17
@gaojude gaojude merged commit f612720 into canary Jan 9, 2025
125 of 130 checks passed
@gaojude gaojude deleted the 01-08-consolidate_static_route_to_dev_tools_indicator branch January 9, 2025 18:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants