-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: exclude the ts testing files from tsconfig during local dev in nextjs repo #74647
test: exclude the ts testing files from tsconfig during local dev in nextjs repo #74647
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Test Passed |
Stats from current PRDefault BuildGeneral Overall increase
|
vercel/next.js canary | vercel/next.js huozhi/01-08-test_exclude_the_ts_testing_files_from_tsconfig_during_local_dev_in_nextjs_repo | Change | |
---|---|---|---|
buildDuration | 38.5s | 36.1s | N/A |
buildDurationCached | 40.1s | 29s | N/A |
nodeModulesSize | 417 MB | 417 MB | |
nextStartRea..uration (ms) | 821ms | 802ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js huozhi/01-08-test_exclude_the_ts_testing_files_from_tsconfig_during_local_dev_in_nextjs_repo | Change | |
---|---|---|---|
1187-HASH.js gzip | 52.6 kB | 52.6 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.44 kB | 5.44 kB | N/A |
bccd1874-HASH.js gzip | 53 kB | 53 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 232 B | 233 B | N/A |
main-HASH.js gzip | 34.1 kB | 34.1 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js huozhi/01-08-test_exclude_the_ts_testing_files_from_tsconfig_during_local_dev_in_nextjs_repo | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js huozhi/01-08-test_exclude_the_ts_testing_files_from_tsconfig_during_local_dev_in_nextjs_repo | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.57 kB | 4.57 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js huozhi/01-08-test_exclude_the_ts_testing_files_from_tsconfig_during_local_dev_in_nextjs_repo | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js huozhi/01-08-test_exclude_the_ts_testing_files_from_tsconfig_during_local_dev_in_nextjs_repo | Change | |
---|---|---|---|
index.html gzip | 524 B | 524 B | ✓ |
link.html gzip | 539 B | 538 B | N/A |
withRouter.html gzip | 520 B | 521 B | N/A |
Overall change | 524 B | 524 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js huozhi/01-08-test_exclude_the_ts_testing_files_from_tsconfig_during_local_dev_in_nextjs_repo | Change | |
---|---|---|---|
edge-ssr.js gzip | 128 kB | 128 kB | N/A |
page.js gzip | 206 kB | 206 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js huozhi/01-08-test_exclude_the_ts_testing_files_from_tsconfig_during_local_dev_in_nextjs_repo | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 668 B | 668 B | ✓ |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.2 kB | 31.2 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 1.51 kB | 1.51 kB | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js huozhi/01-08-test_exclude_the_ts_testing_files_from_tsconfig_during_local_dev_in_nextjs_repo | Change | |
---|---|---|---|
274-experime...dev.js gzip | 322 B | 322 B | ✓ |
274.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 364 kB | 364 kB | ✓ |
app-page-exp..prod.js gzip | 129 kB | 129 kB | ✓ |
app-page-tur..prod.js gzip | 142 kB | 142 kB | ✓ |
app-page-tur..prod.js gzip | 138 kB | 138 kB | ✓ |
app-page.run...dev.js gzip | 352 kB | 352 kB | ✓ |
app-page.run..prod.js gzip | 125 kB | 125 kB | ✓ |
app-route-ex...dev.js gzip | 37.5 kB | 37.5 kB | ✓ |
app-route-ex..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
app-route.ru...dev.js gzip | 39.2 kB | 39.2 kB | ✓ |
app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
pages.runtim...dev.js gzip | 27.5 kB | 27.5 kB | ✓ |
pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.45 MB | 2.45 MB | ✓ |
build cache
vercel/next.js canary | vercel/next.js huozhi/01-08-test_exclude_the_ts_testing_files_from_tsconfig_during_local_dev_in_nextjs_repo | Change | |
---|---|---|---|
0.pack gzip | 2.09 MB | 2.09 MB | N/A |
index.pack gzip | 73.7 kB | 73.4 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Diff details
Diff for main-HASH.js
Diff too large to display
Notifying the following users due to files changed in this PR based on this repo's notify modifiers: @timneutkens, @ijjk, @shuding:
|
Failing test suitesCommit: 6f7d6d3
Expand output● app-dir action disallowed origins › should error if x-forwarded-host does not match the origin
● Test suite failed to run
Read more about building and testing Next.js in contributing.md.
Expand output● using root matcher › adds the header to the /
● using root matcher › adds the header to the /index
● using root matcher › adds the header for a matched data path (with header)
● using root matcher › adds the header for a matched data path (without header)
● using a single matcher with i18n › adds the header for a matched path
● using a single matcher with i18n › adds the header for a mathed root path with /index
● using a single matcher with i18n › adds the headers for a matched data path
● using a single matcher with i18n › does not add the header for an unmatched path
● using a single matcher with i18n and basePath › adds the header for a matched path
● using a single matcher with i18n and basePath › adds the header for a mathed root path with /index
● using a single matcher with i18n and basePath › adds the headers for a matched data path
● using a single matcher with i18n and basePath › does not add the header for an unmatched path
● using a single matcher with i18n and basePath and trailingSlash › adds the header for a matched path
● using a single matcher with i18n and basePath and trailingSlash › adds the header for a mathed root path with /index
● using a single matcher with i18n and basePath and trailingSlash › adds the headers for a matched data path
● using a single matcher with i18n and basePath and trailingSlash › does not add the header for an unmatched path
● Test suite failed to run
● Test suite failed to run
● Test suite failed to run
● Test suite failed to run
Read more about building and testing Next.js in contributing.md.
Expand output● scripts › encodes characters in app router
● scripts › encodes characters in pages router
● styles › encodes characters in app router
● styles › encodes characters in pages router
Read more about building and testing Next.js in contributing.md. |
Follow up on #74647 , do not log this changes during dev
### What Follow up of #74647, do not enque warnings otherwise it's showing a message of updating `tsconfig.json` inside nextjs monorepo when you do `pnpm next <app path>` ``` We detected TypeScript in your project and reconfigured your tsconfig.json file for you. Strict-mode is set to false by default. ``` This is because when there's action we'll always log this.
What
We're suffering from local dev that every time the
*.test.ts
files are resolved with the local tsconfig.json, which was intended to be handled by the root tsconfig.json in the Next.js monorepo as they require to resolve the utils alias.By leveraing the
NEXT_PRIVATE_SKIP_CANARY_CHECK
flag which is renamed toNEXT_PRIVATE_LOCAL_DEV
for our development. This only happen in local development in our monorepo, not in development of users or any other situations.Benefits
This helps us to always write the tests with correct type hints especially for the rare cheerio or playwright interface APIs with our testing suite