Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generic dev build indicator #74615

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

gaojude
Copy link
Contributor

@gaojude gaojude commented Jan 7, 2025

  • Decoupled pages router specific logic from the dev build indicator to extract a generic version
  • Created a pages router specific initialize function for dev build indicator to be called on pages router hydration
  • This prepares for upcoming work on the dev build indicator for App router
  • Covered by e2e test

@gaojude gaojude marked this pull request as ready for review January 7, 2025 19:58
Copy link
Contributor Author

gaojude commented Jan 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Jan 7, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js jude/refactor-dev-build-indicator Change
buildDuration 27.3s 29.7s ⚠️ +2.4s
buildDurationCached 26.4s 23.3s N/A
nodeModulesSize 417 MB 417 MB ⚠️ +7.62 kB
nextStartRea..uration (ms) 758ms 867ms ⚠️ +109ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js jude/refactor-dev-build-indicator Change
1187-HASH.js gzip 52.6 kB 52.6 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js jude/refactor-dev-build-indicator Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js jude/refactor-dev-build-indicator Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js jude/refactor-dev-build-indicator Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js jude/refactor-dev-build-indicator Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js jude/refactor-dev-build-indicator Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js jude/refactor-dev-build-indicator Change
middleware-b..fest.js gzip 669 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js jude/refactor-dev-build-indicator Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 364 kB 364 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 352 kB 352 kB
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.45 MB 2.45 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js jude/refactor-dev-build-indicator Change
0.pack gzip 2.08 MB 2.09 MB ⚠️ +6.36 kB
index.pack gzip 74 kB 74.5 kB ⚠️ +532 B
Overall change 2.16 MB 2.16 MB ⚠️ +6.89 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: df85b4f

@gaojude gaojude changed the title refactor refactor: generic dev build indicator Jan 7, 2025
@gaojude gaojude changed the title refactor: generic dev build indicator refactor: router-agnostic dev build indicator Jan 7, 2025
@gaojude gaojude changed the title refactor: router-agnostic dev build indicator refactor: generic dev build indicator Jan 7, 2025
@gaojude gaojude force-pushed the jude/refactor-dev-build-indicator branch 2 times, most recently from da42667 to 725a8f6 Compare January 7, 2025 20:23
@gaojude gaojude requested a review from devjiwonchoi January 7, 2025 20:24
@gaojude gaojude force-pushed the jude/refactor-dev-build-indicator branch from 725a8f6 to 8af97a9 Compare January 7, 2025 20:25
@gaojude gaojude requested a review from huozhi January 7, 2025 20:26
@ijjk
Copy link
Member

ijjk commented Jan 7, 2025

Tests Passed

@gaojude gaojude force-pushed the jude/refactor-dev-build-indicator branch from 8af97a9 to fb2df7e Compare January 7, 2025 21:01
@gaojude gaojude requested a review from huozhi January 7, 2025 21:02
@gaojude gaojude force-pushed the jude/refactor-dev-build-indicator branch from fb2df7e to 4a8fb40 Compare January 7, 2025 21:05
@gaojude gaojude force-pushed the jude/refactor-dev-build-indicator branch from 4a8fb40 to df85b4f Compare January 7, 2025 21:05
@gaojude gaojude merged commit 5c49eec into canary Jan 7, 2025
125 of 130 checks passed
@gaojude gaojude deleted the jude/refactor-dev-build-indicator branch January 7, 2025 22:54
wbinnssmith pushed a commit that referenced this pull request Jan 10, 2025
- Decoupled pages router specific logic from the dev build indicator to
extract a generic version
- Created a pages router specific initialize function for dev build
indicator to be called on pages router hydration
- This prepares for upcoming work on the dev build indicator for App
router
- Covered by [e2e
test](https://github.com/vercel/next.js/blob/jude/refactor-dev-build-indicator/test/integration/build-indicator/test/index.test.js)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants