Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing await for hydration test #74542

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 6, 2025

The retry() call needs to be awaited, where the callback keeps get invoked while new errors are being added to the error queue.

x-ref: https://github.com/vercel/next.js/actions/runs/12629855744/job/35188630034?pr=74262
x-ref: https://github.com/vercel/next.js/actions/runs/12630087365/job/35189250327?pr=74542

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Jan 6, 2025
Copy link
Member Author

huozhi commented Jan 6, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@huozhi huozhi marked this pull request as ready for review January 6, 2025 09:39
@ijjk
Copy link
Member

ijjk commented Jan 6, 2025

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js huozhi01-06-fix-flaky-hydration-test Change
buildDuration 20.7s 19s N/A
buildDurationCached 18.1s 15.4s N/A
nodeModulesSize 417 MB 417 MB
nextStartRea..uration (ms) 513ms 516ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js huozhi01-06-fix-flaky-hydration-test Change
1187-HASH.js gzip 52.6 kB 52.6 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js huozhi01-06-fix-flaky-hydration-test Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js huozhi01-06-fix-flaky-hydration-test Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js huozhi01-06-fix-flaky-hydration-test Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js huozhi01-06-fix-flaky-hydration-test Change
index.html gzip 524 B 523 B N/A
link.html gzip 540 B 537 B N/A
withRouter.html gzip 521 B 520 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js huozhi01-06-fix-flaky-hydration-test Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js huozhi01-06-fix-flaky-hydration-test Change
middleware-b..fest.js gzip 673 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js huozhi01-06-fix-flaky-hydration-test Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 363 kB 363 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 352 kB 352 kB
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.44 MB 2.44 MB
build cache
vercel/next.js canary vercel/next.js huozhi01-06-fix-flaky-hydration-test Change
0.pack gzip 2.09 MB 2.08 MB N/A
index.pack gzip 74 kB 74.1 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 3b708c2

@ijjk
Copy link
Member

ijjk commented Jan 6, 2025

Tests Passed

@huozhi huozhi merged commit 4c5fa1d into canary Jan 6, 2025
130 checks passed
@huozhi huozhi deleted the huozhi01-06-fix-flaky-hydration-test branch January 6, 2025 10:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants