chore(examples): updated the example of with-react-jss to utlize the App router #74440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
@Manoj-M-S I just realized this dependency is no longer maintained so we should remove this example. |
samcx
approved these changes
Jan 7, 2025
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/react-jss@10.10.0 |
wbinnssmith
pushed a commit
that referenced
this pull request
Jan 10, 2025
…App router (#74440) This PR updates the with-react-jss example to use the App Router. Here are the changes that have been made: - Renamed the `pages` folder to the `app` folder. - Converted the `index.tsx `to `page.tsx` file as part of the App Router. - Created `layout.tsx` in app directory, merging functionality from both `_app.tsx` and `_document.tsx`: - Wraps content with `StyledComponentsRegistry` - Created `app/registry.tsx` for JSS setup: - Moved JSS Provider and SheetsRegistry from _document.tsx - Moved style cleanup logic from _app.tsx - Handles server-side style generation - Updated the package.json file. The following actions were performed as part of this PR: - Ran `pnpm prettier-check` with no issues found. - Executed the `pnpm check-examples` script. CC: @samcx --------- Co-authored-by: samcx <sam@vercel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the with-react-jss example to use the App Router. Here are the changes that have been made:
pagesfolder to theappfolder.index.tsxtopage.tsxfile as part of the App Router.layout.tsxin app directory, merging functionality from both_app.tsxand_document.tsx:StyledComponentsRegistryapp/registry.tsxfor JSS setup:The following actions were performed as part of this PR:
pnpm prettier-checkwith no issues found.pnpm check-examplesscript.CC: @samcx