-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed duplicated cn function declaration from lib dir #74065
Removed duplicated cn function declaration from lib dir #74065
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
@samcx Hey, here is the pr as discussed. it feels a little wrong leaving an empty |
@damiensedgwick Can you make sure to update the path imports? Also seeing an issue with the Tailwind CSS. You can test this locally with |
Fixed the issue with component imports. I actually realised that I removed the wrong instance at first so that has been corrected. Regarding tailwind, this is a weird error because I have not touched anything Tailwind related but also, the error I am getting
Does not make sense because the class is within a layer directive as we can see here: @layer base {
* {
@apply border-border;
}
body {
@apply bg-background text-foreground;
}
} So I am not entirely sure what you would like me to do here. This is exactly how the css file is setup within every project using shad that I have seen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a PR!
This pull request removes duplication of a utility function within the
with-supabase
example as mentioned in the following issue #73942 - I removed the duplicated code from theutils
directory as when shadcn installs a new component, that component will look for the helper function inlib/utils.ts
and forcing users to update every component after installation or modify any config files for shadcn seems like a worse DX.