Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(turbopack): Fix build error when CI environment variable is not supplied #74041

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

bgw
Copy link
Member

@bgw bgw commented Dec 17, 2024

Fixes:

error: environment variable `CI` not defined at compile time
   --> crates/napi/src/next_api/utils.rs:130:59
    |
130 |         let dirty_suffix = if crate::build::GIT_CLEAN || !env!("CI").is_empty() {
    |                                                           ^^^^^^^^^^
    |
    = help: use `std::env::var("CI")` to read the variable at run time
    = note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `next-swc-napi` (lib) due to 1 previous error

Closes PACK-3663

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Dec 17, 2024
Copy link
Member Author

bgw commented Dec 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bgw bgw marked this pull request as ready for review December 17, 2024 19:43
@bgw bgw requested a review from sokra December 17, 2024 19:45
@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Tests Passed

@bgw bgw requested review from kdy1, mischnic and wbinnssmith December 17, 2024 20:31
@bgw bgw merged commit 65d2228 into canary Dec 17, 2024
124 of 130 checks passed
Copy link
Member Author

bgw commented Dec 17, 2024

Merge activity

  • Dec 17, 3:44 PM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/option-ci branch December 17, 2024 20:44
@github-actions github-actions bot added the locked label Jan 1, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants