Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor telemetry API #73865

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Refactor telemetry API #73865

merged 1 commit into from
Dec 13, 2024

Conversation

gaojude
Copy link
Contributor

@gaojude gaojude commented Dec 12, 2024

This change refactors the code that sends an API request to the telemetry backend to a dedicated function. It also adds test coverage for that function. This is a preliminary cleanup that enables the new error overlay to reuse this endpoint to send feedback tracking.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 12, 2024
@ijjk
Copy link
Member

ijjk commented Dec 12, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js jude/extract-post-payload-call Change
buildDuration 16s 14.3s N/A
buildDurationCached 13.5s 11.3s N/A
nodeModulesSize 410 MB 410 MB ⚠️ +13.8 kB
nextStartRea..uration (ms) 416ms 411ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js jude/extract-post-payload-call Change
1187-HASH.js gzip 50.8 kB 50.8 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js jude/extract-post-payload-call Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js jude/extract-post-payload-call Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js jude/extract-post-payload-call Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js jude/extract-post-payload-call Change
index.html gzip 525 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js jude/extract-post-payload-call Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js jude/extract-post-payload-call Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js jude/extract-post-payload-call Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 323 kB 323 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 313 kB 313 kB
app-page.run..prod.js gzip 123 kB 123 kB
app-route-ex...dev.js gzip 37.3 kB 37.3 kB
app-route-ex..prod.js gzip 25.3 kB 25.3 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route-tu..prod.js gzip 25.2 kB 25.2 kB
app-route.ru...dev.js gzip 38.9 kB 38.9 kB
app-route.ru..prod.js gzip 25.2 kB 25.2 kB
pages-api-tu..prod.js gzip 9.67 kB 9.67 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.67 kB 9.67 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.36 MB 2.36 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js jude/extract-post-payload-call Change
0.pack gzip 2.05 MB 2.05 MB ⚠️ +2.96 kB
index.pack gzip 73.1 kB 72.5 kB N/A
Overall change 2.05 MB 2.05 MB ⚠️ +2.96 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 8fd90c6

@gaojude gaojude force-pushed the jude/extract-post-payload-call branch from c01828b to 238867c Compare December 12, 2024 21:26
@ijjk ijjk added the Turbopack Related to Turbopack with Next.js. label Dec 12, 2024
@gaojude gaojude changed the base branch from canary to jude/more-error-classes December 12, 2024 21:26
Copy link
Contributor Author

gaojude commented Dec 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gaojude gaojude force-pushed the jude/extract-post-payload-call branch from 238867c to 54144f3 Compare December 12, 2024 21:34
@gaojude gaojude changed the base branch from jude/more-error-classes to exclude_error_code_for_test_files December 12, 2024 21:35
@ijjk
Copy link
Member

ijjk commented Dec 12, 2024

Tests Passed

@gaojude gaojude force-pushed the exclude_error_code_for_test_files branch from 31baaf6 to 089e38a Compare December 12, 2024 21:49
@gaojude gaojude force-pushed the jude/extract-post-payload-call branch from 54144f3 to ef8b382 Compare December 12, 2024 21:49
@gaojude gaojude force-pushed the jude/extract-post-payload-call branch from ef8b382 to 0cae107 Compare December 12, 2024 22:48
@gaojude gaojude changed the base branch from exclude_error_code_for_test_files to canary December 12, 2024 22:48
@gaojude gaojude force-pushed the jude/extract-post-payload-call branch from 0cae107 to 46c9f56 Compare December 12, 2024 22:58
@ijjk ijjk added the tests label Dec 12, 2024
@gaojude gaojude changed the base branch from canary to exclude_error_code_for_test_files December 12, 2024 22:58
@gaojude gaojude force-pushed the exclude_error_code_for_test_files branch from 405386e to a6d8cec Compare December 12, 2024 23:21
Base automatically changed from exclude_error_code_for_test_files to canary December 13, 2024 00:08
@gaojude gaojude force-pushed the jude/extract-post-payload-call branch from 46c9f56 to 8fd90c6 Compare December 13, 2024 00:09
@gaojude gaojude changed the title Refactor post-telemetry-payload Refactor telemetry API Dec 13, 2024
@gaojude gaojude merged commit c824a7a into canary Dec 13, 2024
113 checks passed
@gaojude gaojude deleted the jude/extract-post-payload-call branch December 13, 2024 01:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked tests Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants