Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbopack: store ChunkingType in single-module-graph #73837

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Dec 12, 2024

Based on #73572

  • Model ChunkingType with Petgraph edges instead of Nodes
  • For now, I removed the SingleModuleGraphNode::Chunk variant again. I don't need it right now and I'm not convinced that all the other usecases apart from chunking should have to constantly deal with that enum variant. And it's the Single Module Graph after all 🤷‍♂️
    But we can of course still add it if we need it once we need it

No measureable performance impact

Closes PACK-3651

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Dec 12, 2024
Copy link
Contributor Author

mischnic commented Dec 12, 2024

@mischnic mischnic changed the title Implement a chunk graph using a single graph traversal Turbopack: store ChunkingType in single-module-graph Dec 12, 2024
@ijjk
Copy link
Member

ijjk commented Dec 12, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 12, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js mischnic/single-graph-edge-type Change
buildDuration 18.9s 16.9s N/A
buildDurationCached 16s 13.7s N/A
nodeModulesSize 410 MB 410 MB N/A
nextStartRea..uration (ms) 479ms 488ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mischnic/single-graph-edge-type Change
1187-HASH.js gzip 50.8 kB 50.8 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mischnic/single-graph-edge-type Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js mischnic/single-graph-edge-type Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js mischnic/single-graph-edge-type Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js mischnic/single-graph-edge-type Change
index.html gzip 525 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mischnic/single-graph-edge-type Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js mischnic/single-graph-edge-type Change
middleware-b..fest.js gzip 670 B 669 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js mischnic/single-graph-edge-type Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 323 kB 323 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 313 kB 313 kB
app-page.run..prod.js gzip 123 kB 123 kB
app-route-ex...dev.js gzip 37.3 kB 37.3 kB
app-route-ex..prod.js gzip 25.3 kB 25.3 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route-tu..prod.js gzip 25.2 kB 25.2 kB
app-route.ru...dev.js gzip 38.9 kB 38.9 kB
app-route.ru..prod.js gzip 25.2 kB 25.2 kB
pages-api-tu..prod.js gzip 9.67 kB 9.67 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.67 kB 9.67 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.36 MB 2.36 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js mischnic/single-graph-edge-type Change
0.pack gzip 2.05 MB 2.05 MB ⚠️ +1.62 kB
index.pack gzip 72.5 kB 72.1 kB N/A
Overall change 2.05 MB 2.05 MB ⚠️ +1.62 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 2cd4af9

@mischnic mischnic marked this pull request as ready for review December 12, 2024 14:34
wbinnssmith and others added 8 commits December 13, 2024 14:51
This uses our single graph traversal architecture to create a chunk graph capable of determining which chunks require which (parallel) modules and which modules belong to which chunks.

Currently, it integrates the chunking type of the dependency on the module into graph node itself.
@mischnic mischnic force-pushed the mischnic/single-graph-edge-type branch from d053c5d to 2cd4af9 Compare December 13, 2024 13:52
@mischnic mischnic merged commit 4ba5843 into canary Dec 13, 2024
116 checks passed
@mischnic mischnic deleted the mischnic/single-graph-edge-type branch December 13, 2024 19:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants