Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove segmentPath from RSC payload #73827

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

acdlite
Copy link
Contributor

@acdlite acdlite commented Dec 12, 2024

Based on:


This removes the segmentPath prop from the LayoutRouter payload. This can be derived on the client from the FlightRouterState instead.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 12, 2024
@acdlite acdlite force-pushed the remove-segmentpath-prop branch from fe2429e to fb5280c Compare December 12, 2024 04:16
@ijjk ijjk added the tests label Dec 12, 2024
@ijjk
Copy link
Member

ijjk commented Dec 12, 2024

Tests Passed

@acdlite acdlite force-pushed the remove-segmentpath-prop branch from fb5280c to 4405f52 Compare December 12, 2024 04:23
@ijjk
Copy link
Member

ijjk commented Dec 12, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary acdlite/next.js remove-segmentpath-prop Change
buildDuration 23s 19.4s N/A
buildDurationCached 18.4s 15.6s N/A
nodeModulesSize 409 MB 409 MB N/A
nextStartRea..uration (ms) 539ms 521ms N/A
Client Bundles (main, webpack)
vercel/next.js canary acdlite/next.js remove-segmentpath-prop Change
1187-HASH.js gzip 50.7 kB 50.7 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary acdlite/next.js remove-segmentpath-prop Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary acdlite/next.js remove-segmentpath-prop Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary acdlite/next.js remove-segmentpath-prop Change
_buildManifest.js gzip 747 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary acdlite/next.js remove-segmentpath-prop Change
index.html gzip 524 B 522 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary acdlite/next.js remove-segmentpath-prop Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary acdlite/next.js remove-segmentpath-prop Change
middleware-b..fest.js gzip 671 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary acdlite/next.js remove-segmentpath-prop Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 323 kB 323 kB N/A
app-page-exp..prod.js gzip 127 kB 127 kB N/A
app-page-tur..prod.js gzip 140 kB 140 kB N/A
app-page-tur..prod.js gzip 135 kB 135 kB N/A
app-page.run...dev.js gzip 313 kB 313 kB N/A
app-page.run..prod.js gzip 123 kB 123 kB N/A
app-route-ex...dev.js gzip 37.3 kB 37.3 kB
app-route-ex..prod.js gzip 25.4 kB 25.4 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route-tu..prod.js gzip 25.2 kB 25.2 kB
app-route.ru...dev.js gzip 38.9 kB 38.9 kB
app-route.ru..prod.js gzip 25.2 kB 25.2 kB
pages-api-tu..prod.js gzip 9.67 kB 9.67 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.66 kB 9.66 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.2 MB 1.2 MB
build cache Overall increase ⚠️
vercel/next.js canary acdlite/next.js remove-segmentpath-prop Change
0.pack gzip 2.05 MB 2.05 MB ⚠️ +211 B
index.pack gzip 71.9 kB 73 kB ⚠️ +1.11 kB
Overall change 2.12 MB 2.13 MB ⚠️ +1.32 kB
Diff details
Diff for 1187-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: 97312cf

@acdlite acdlite force-pushed the remove-segmentpath-prop branch 3 times, most recently from 666517b to 4f5191c Compare December 12, 2024 05:54
@acdlite acdlite marked this pull request as ready for review December 12, 2024 07:01
@acdlite acdlite requested a review from ztanner December 12, 2024 07:01
This removes the `segmentPath` prop from the LayoutRouter payload. This
can be derived on the client from the FlightRouterState instead.
@acdlite acdlite force-pushed the remove-segmentpath-prop branch from 4f5191c to 97312cf Compare December 12, 2024 15:45
@acdlite acdlite enabled auto-merge (squash) December 12, 2024 16:29
@acdlite acdlite merged commit 546f022 into vercel:canary Dec 12, 2024
86 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants