Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Fix config file conflict #73818

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[E2E] Fix config file conflict #73818

merged 1 commit into from
Dec 11, 2024

Conversation

gaojude
Copy link
Contributor

@gaojude gaojude commented Dec 11, 2024

Background

  1. next start finds a next.config upwards in the file system from the current directory
  2. /test/integration/telemetry test outputs a next.config to the E2E root directory
  3. Tests run in parallel in CI
  4. This is Part 2 of (E2E) Log which config file is used for next start #73105

Problem

After /test/integration/telemetry generates the config at the root but before it completes to clean it up, other tests might be running and kicking off next start which happens to locate the config generated by /test/integration/telemetry, since it was misplaced at the root. (This PR fixes it by placing it at the project itself)

Notably, /test/integration/telemetry generates a config with module.exports = { output: "export" }, so when conflict occurs, next start would exit with error like:

Error: "next start" does not work with "output: export" configuration. Use "npx serve@latest out" instead.

https://github.com/vercel/next.js/actions/runs/12272870280/job/34244194091?pr=73322

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Dec 11, 2024
@gaojude gaojude requested a review from mischnic December 11, 2024 21:12
@ijjk
Copy link
Member

ijjk commented Dec 11, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 11, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js jude/extraneous-config Change
buildDuration 29.1s 27.7s N/A
buildDurationCached 24.4s 22.5s N/A
nodeModulesSize 409 MB 409 MB
nextStartRea..uration (ms) 795ms 720ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js jude/extraneous-config Change
1187-HASH.js gzip 50.7 kB 50.7 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 34 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js jude/extraneous-config Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js jude/extraneous-config Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js jude/extraneous-config Change
_buildManifest.js gzip 747 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js jude/extraneous-config Change
index.html gzip 524 B 524 B
link.html gzip 539 B 539 B
withRouter.html gzip 520 B 520 B
Overall change 1.58 kB 1.58 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js jude/extraneous-config Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js jude/extraneous-config Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js jude/extraneous-config Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 323 kB 323 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 313 kB 313 kB
app-page.run..prod.js gzip 123 kB 123 kB
app-route-ex...dev.js gzip 37.3 kB 37.3 kB
app-route-ex..prod.js gzip 25.4 kB 25.4 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route-tu..prod.js gzip 25.2 kB 25.2 kB
app-route.ru...dev.js gzip 38.9 kB 38.9 kB
app-route.ru..prod.js gzip 25.2 kB 25.2 kB
pages-api-tu..prod.js gzip 9.67 kB 9.67 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.66 kB 9.66 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.36 MB 2.36 MB
build cache
vercel/next.js canary vercel/next.js jude/extraneous-config Change
0.pack gzip 2.05 MB 2.05 MB N/A
index.pack gzip 72.7 kB 72.2 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: fa172db

@gaojude gaojude merged commit 6c3a8a0 into canary Dec 11, 2024
108 of 113 checks passed
@gaojude gaojude deleted the jude/extraneous-config branch December 11, 2024 22:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants