Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(turbo-tasks): Implement NonLocalValue for State<T> where T: NonLocalValue #73770

Merged
merged 1 commit into from
Dec 13, 2024
Merged

refactor(turbo-tasks): Implement NonLocalValue for State<T> where T: NonLocalValue #73770

merged 1 commit into from
Dec 13, 2024

Conversation

bgw
Copy link
Member

@bgw bgw commented Dec 10, 2024 •
edited by padmaia
Loading

Title says it all. This lets us implement NonLocalValue on more structs.

What is NonLocalValue? https://turbopack-rust-docs.vercel.sh/rustdoc/turbo_tasks/trait.NonLocalValue.html

Closes PACK-3648

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Dec 10, 2024
@bgw bgw mentioned this pull request Dec 10, 2024
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Dec 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bgw bgw mentioned this pull request Dec 10, 2024
Merged
@ijjk
Copy link
Member

ijjk commented Dec 10, 2024 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js bgw/impl-state-non-local Change
buildDuration 20s 18.4s N/A
buildDurationCached 17.5s 14.7s N/A
nodeModulesSize 410 MB 410 MB ✓
nextStartRea..uration (ms) 514ms 502ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/impl-state-non-local Change
1187-HASH.js gzip 50.8 kB 50.8 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/impl-state-non-local Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bgw/impl-state-non-local Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/impl-state-non-local Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/impl-state-non-local Change
index.html gzip 525 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 521 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/impl-state-non-local Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js bgw/impl-state-non-local Change
middleware-b..fest.js gzip 670 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js bgw/impl-state-non-local Change
523-experime...dev.js gzip 322 B 322 B ✓
523.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 323 kB 323 kB ✓
app-page-exp..prod.js gzip 127 kB 127 kB ✓
app-page-tur..prod.js gzip 140 kB 140 kB ✓
app-page-tur..prod.js gzip 135 kB 135 kB ✓
app-page.run...dev.js gzip 313 kB 313 kB ✓
app-page.run..prod.js gzip 123 kB 123 kB ✓
app-route-ex...dev.js gzip 37.3 kB 37.3 kB ✓
app-route-ex..prod.js gzip 25.3 kB 25.3 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route-tu..prod.js gzip 25.2 kB 25.2 kB ✓
app-route.ru...dev.js gzip 38.9 kB 38.9 kB ✓
app-route.ru..prod.js gzip 25.2 kB 25.2 kB ✓
pages-api-tu..prod.js gzip 9.67 kB 9.67 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.67 kB 9.67 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.4 kB 27.4 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.36 MB 2.36 MB ✓
build cache
vercel/next.js canary vercel/next.js bgw/impl-state-non-local Change
0.pack gzip 2.05 MB 2.05 MB N/A
index.pack gzip 72.1 kB 71.8 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: b80c18a

@ijjk
Copy link
Member

ijjk commented Dec 10, 2024 •
edited
Loading

Tests Passed

@bgw bgw force-pushed the bgw/non-local-default branch from abbdd33 to bc4a70d Compare December 10, 2024 23:15
@bgw bgw force-pushed the bgw/impl-state-non-local branch from 52bada1 to b8fe36f Compare December 10, 2024 23:15
@bgw bgw marked this pull request as ready for review December 10, 2024 23:15
@bgw bgw mentioned this pull request Dec 10, 2024
Merged
@bgw bgw requested review from kdy1 and mischnic December 10, 2024 23:26
@bgw bgw force-pushed the bgw/non-local-default branch from bc4a70d to 60e3fcd Compare December 10, 2024 23:45
@bgw bgw force-pushed the bgw/impl-state-non-local branch from b8fe36f to 9c9bbb0 Compare December 10, 2024 23:45
@bgw bgw force-pushed the bgw/non-local-default branch from 60e3fcd to 20df3b7 Compare December 11, 2024 18:41
@bgw bgw force-pushed the bgw/impl-state-non-local branch from 9c9bbb0 to 76e4a93 Compare December 11, 2024 18:41
@bgw bgw force-pushed the bgw/non-local-default branch from 20df3b7 to 56f8361 Compare December 11, 2024 18:59
@bgw bgw force-pushed the bgw/impl-state-non-local branch from 76e4a93 to 78c26c4 Compare December 11, 2024 18:59
@bgw bgw force-pushed the bgw/non-local-default branch 2 times, most recently from fa5306c to 1ded04c Compare December 11, 2024 19:24
@bgw bgw force-pushed the bgw/impl-state-non-local branch from 78c26c4 to 790e90e Compare December 11, 2024 19:24
@bgw bgw force-pushed the bgw/non-local-default branch from 1ded04c to e38ba3b Compare December 12, 2024 23:07
@bgw bgw changed the base branch from bgw/non-local-default to graphite-base/73770 December 12, 2024 23:49
@bgw bgw force-pushed the bgw/impl-state-non-local branch from 790e90e to 10fc434 Compare December 12, 2024 23:50
@bgw bgw force-pushed the graphite-base/73770 branch from e38ba3b to 0ad304c Compare December 12, 2024 23:50
@bgw bgw changed the base branch from graphite-base/73770 to canary December 12, 2024 23:51
@bgw bgw force-pushed the bgw/impl-state-non-local branch from 10fc434 to f966ed3 Compare December 12, 2024 23:51
@bgw bgw force-pushed the bgw/impl-state-non-local branch from f966ed3 to b80c18a Compare December 13, 2024 00:26
@bgw bgw merged commit af1b74f into canary Dec 13, 2024
114 checks passed
@bgw bgw deleted the bgw/impl-state-non-local branch December 13, 2024 02:42
This was referenced Dec 13, 2024
Merged
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mischnic mischnic mischnic approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bgw @ijjk @mischnic @kdy1