Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-overlay] hide dev overlay when printing #73489

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

lachlanjc
Copy link
Contributor

@lachlanjc lachlanjc commented Dec 4, 2024

While this behavior is not clearly a bug, when I'm debugging print styling in Next.js, seeing the Next.js dev overlay UI is distracting and unnecessary:

image

A few lines of CSS can hide it in that context only. I don't think this CSS rule needs an integration test, but let me know if so.


Jiwon: Since the dev indicator will always be visible, it is a good default to hide it when printing.

@ijjk ijjk added the type: next label Dec 4, 2024
@ijjk
Copy link
Member

ijjk commented Dec 4, 2024

Allow CI Workflow Run

  • approve CI run for commit: 94c4ac9

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@eps1lon eps1lon requested a review from huozhi December 4, 2024 00:40
@ijjk
Copy link
Member

ijjk commented Dec 4, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary alitas/next.js patch-3 Change
buildDuration 23.3s 21.8s N/A
buildDurationCached 20.7s 18.3s N/A
nodeModulesSize 409 MB 409 MB N/A
nextStartRea..uration (ms) 544ms 527ms N/A
Client Bundles (main, webpack)
vercel/next.js canary alitas/next.js patch-3 Change
1187-HASH.js gzip 50.2 kB 50.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary alitas/next.js patch-3 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary alitas/next.js patch-3 Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.75 kB 1.75 kB
Client Build Manifests
vercel/next.js canary alitas/next.js patch-3 Change
_buildManifest.js gzip 746 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary alitas/next.js patch-3 Change
index.html gzip 523 B 522 B N/A
link.html gzip 536 B 537 B N/A
withRouter.html gzip 518 B 520 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary alitas/next.js patch-3 Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary alitas/next.js patch-3 Change
middleware-b..fest.js gzip 666 B 666 B
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 1.51 kB 1.51 kB
Next Runtimes
vercel/next.js canary alitas/next.js patch-3 Change
797-experime...dev.js gzip 322 B 322 B
797.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 322 kB 322 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 312 kB 312 kB
app-page.run..prod.js gzip 122 kB 122 kB
app-route-ex...dev.js gzip 37.1 kB 37.1 kB
app-route-ex..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 24.9 kB 24.9 kB
app-route.ru...dev.js gzip 38.7 kB 38.7 kB
app-route.ru..prod.js gzip 24.9 kB 24.9 kB
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB
pages-turbo...prod.js gzip 21.3 kB 21.3 kB
pages.runtim...dev.js gzip 27 kB 27 kB
pages.runtim..prod.js gzip 21.3 kB 21.3 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.35 MB 2.35 MB
build cache Overall increase ⚠️
vercel/next.js canary alitas/next.js patch-3 Change
0.pack gzip 2.04 MB 2.04 MB ⚠️ +2 kB
index.pack gzip 145 kB 145 kB N/A
Overall change 2.04 MB 2.04 MB ⚠️ +2 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 45feb8d

@ijjk
Copy link
Member

ijjk commented Dec 4, 2024

Failing test suites

Commit: 45feb8d

pnpm test-dev test/development/acceptance-app/ReactRefreshLogBox.test.ts

  • ReactRefreshLogBox app default > server component can recover from error thrown in the module
Expand output

● ReactRefreshLogBox app default › server component can recover from error thrown in the module

Expected Redbox but found none

  1060 |
  1061 |       await next.patchFile('index.js', "throw new Error('module error')")
> 1062 |       await session.assertHasRedbox()
       |       ^
  1063 |       await next.patchFile(
  1064 |         'index.js',
  1065 |         'export default function Page() {return <p>hello world</p>}'

  at Object.<anonymous> (development/acceptance-app/ReactRefreshLogBox.test.ts:1062:7)

Read more about building and testing Next.js in contributing.md.

Copy link
Member

@devjiwonchoi devjiwonchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@devjiwonchoi devjiwonchoi changed the title Hide dev overlay when printing [dev-overlay] hide dev overlay when printing Feb 14, 2025
@devjiwonchoi devjiwonchoi enabled auto-merge (squash) February 14, 2025 18:46
@devjiwonchoi devjiwonchoi merged commit ab2f35a into vercel:canary Feb 14, 2025
110 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants