Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(use-cache): add missing jsx switcher example and types #73473

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

devpla
Copy link
Contributor

@devpla devpla commented Dec 3, 2024

Hi Team.

This PR improves the documentation for the use-cache directive in the "Interleaving" section by addressing the following issues:

  1. Added missing jsx switcher code blocks, which previously caused some content to disappear when switching to JavaScript due to the absence of corresponding jsx examples.
  2. Included missing TypeScript types in tsx code blocks.
  3. Formatted some code blocks to align with consistent styling across the documentation.

Thank you.

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Dec 3, 2024
@ijjk
Copy link
Member

ijjk commented Dec 3, 2024

Allow CI Workflow Run

  • approve CI run for commit: bbaef77

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@leerob
Copy link
Member

leerob commented Dec 16, 2024

There's merge conflicts here - could you also run Prettier?

@devpla
Copy link
Contributor Author

devpla commented Dec 16, 2024

There's merge conflicts here - could you also run Prettier?

@leerob Thanks for catching that! I've resolved the merge conflicts and ran prettier-check, which passed successfully.

@leerob leerob merged commit 29bdca7 into vercel:canary Dec 16, 2024
39 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants