Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(internalization): add typescript examples and fix params as promise #73240

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

devpla
Copy link
Contributor

@devpla devpla commented Nov 27, 2024

Hi Team.
This PR enhances the internalization documentation by adding TypeScript examples and updating the handling of params as a Promise.

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Nov 27, 2024
@ijjk
Copy link
Member

ijjk commented Nov 27, 2024

Allow CI Workflow Run

  • approve CI run for commit: a17032c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@leerob
Copy link
Member

leerob commented Dec 16, 2024

Could you address the merge conflicts please?

@devpla devpla force-pushed the docs/internationalization branch from 2f6df31 to e65b2c2 Compare December 16, 2024 05:34
@devpla
Copy link
Contributor Author

devpla commented Dec 16, 2024

@leerob Thank you! I’ve resolved the merge conflicts, and the branch is now up to date.

@devpla devpla force-pushed the docs/internationalization branch from e65b2c2 to a17032c Compare December 16, 2024 10:34
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leerob leerob merged commit ec7025e into vercel:canary Dec 16, 2024
39 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants