From 11a3a21bee5d4b58b254e60f4c080ee7349f40be Mon Sep 17 00:00:00 2001
From: Tim Neutkens <tim@timneutkens.nl>
Date: Tue, 18 Feb 2025 10:09:53 +0100
Subject: [PATCH] Improve server actions sourcemap test (#76129)

## What?

Improves the check for browser sourcemaps by reading all sourcemap files
from the `.next/static` folder instead of trying to locate a specific
value. The sensitive value that is being checked should not exist in any
of the sourcemap files so it's safer to check them all. This also
ensures that if for example the underlying bundling heuristics change
the check will still fail. In this case it was failing on the path with
Turbopack, instead of on the value. This ensures it checks the value.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

---------

Co-authored-by: Sebastian "Sebbie" Silbermann <sebastian.silbermann@vercel.com>
---
 test/e2e/app-dir/actions/app-action.test.ts | 26 +++++++++++++--------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/test/e2e/app-dir/actions/app-action.test.ts b/test/e2e/app-dir/actions/app-action.test.ts
index 4577286c917a7..9055cefa959e7 100644
--- a/test/e2e/app-dir/actions/app-action.test.ts
+++ b/test/e2e/app-dir/actions/app-action.test.ts
@@ -9,6 +9,7 @@ import {
 } from 'next-test-utils'
 import type { Page, Request, Response, Route } from 'playwright'
 import fs from 'fs-extra'
+import nodeFs from 'fs'
 import { join } from 'path'
 
 const GENERIC_RSC_ERROR =
@@ -919,19 +920,24 @@ describe('app-dir action handling', () => {
 
   if (isNextStart) {
     it('should not expose action content in sourcemaps', async () => {
-      const sourcemap = (
-        await fs.readdir(
-          join(next.testDir, '.next', 'static', 'chunks', 'app', 'client')
+      // We check all sourcemaps in the `static` folder for sensitive information given that chunking
+      const sourcemaps = nodeFs
+        .readdirSync(join(next.testDir, '.next', 'static'), {
+          recursive: true,
+          encoding: 'utf8',
+        })
+        .filter((f) => f.endsWith('.js.map'))
+        .map((f) =>
+          nodeFs.readFileSync(join(next.testDir, '.next', 'static', f), {
+            encoding: 'utf8',
+          })
         )
-      ).find((f) => f.endsWith('.js.map'))
 
-      expect(sourcemap).toBeDefined()
+      expect(sourcemaps).not.toBeEmpty()
 
-      expect(
-        await next.readFile(
-          join('.next', 'static', 'chunks', 'app', 'client', sourcemap)
-        )
-      ).not.toContain('this_is_sensitive_info')
+      for (const sourcemap of sourcemaps) {
+        expect(sourcemap).not.toContain('this_is_sensitive_info')
+      }
     })
   }