Wmwragg/typography updates #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
awesome - thanks Will. Safari is actually formally supported (see https://github.com/matrix-org/matrix-react-sdk/tree/develop#developer-guide), but you're right that it's a bit of a 2nd class citizen due to lack of WebRTC, so there are some bugs like this one. This closes #1621 thanks! |
|
This also closes #1753 as the main typography issues we were seeing were only on safari. The smaller issues will have to be dealt with separately, at a later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm aware that safari isn't supported at the moment, as it doesn't currently support WebRTC, but it was such a simple and easy fix, that I thought I'd submit it.
Signed-off-by: William Wragg wm.wragg@gmail.com