Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect to see HTTP /join/#some:alias when we the view knows it #4252

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Expect to see HTTP /join/#some:alias when we the view knows it #4252

merged 1 commit into from
Jun 8, 2017

Conversation

lukebarnard1
Copy link
Contributor

No description provided.

@lukebarnard1 lukebarnard1 mentioned this pull request Jun 8, 2017
Merged
richvdh
richvdh approved these changes Jun 8, 2017
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukebarnard1
Copy link
Contributor Author

and of course these tests will fail because of the codependency with matrix-org/matrix-react-sdk#1062

@lukebarnard1 lukebarnard1 merged commit f2b89ac into develop Jun 8, 2017
@t3chguy t3chguy deleted the luke/fix-joining-test branch May 12, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees

@richvdh richvdh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebarnard1 @richvdh