to make the windows volume mixer not explode as it can't resize icons. #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hate Windows. Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
force-pushed
the
t3chguy/electron_logo_windows_weirdness
branch
from
90ae7bb to
25a0af6
Compare
|
Alternative is extracting the red circle badge component of the image and using the actual overlay function, that would mean another lot of canvas etc in the renderer though |
|
|
t3chguy
force-pushed
the
t3chguy/electron_logo_windows_weirdness
branch
from
5e0fa0a to
685d45b
Compare
…delay (not noticeably more than the existing delay) Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
force-pushed
the
t3chguy/electron_logo_windows_weirdness
branch
from
685d45b to
1e5a742
Compare
|
This should fix it, converts png to a proper ico file, have to save it as nativeImage has no proper support for icos and can only load them form a file, can't read from buf etc |
|
fixes #4185 |
|
that's hilarious. lgtm. |
|
Agreed, gotta love Windows ... right!? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
Might not be the best way, probably worth @dbkr looking it over.
I hate Windows.
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com