Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe our existing features better in documentation #10418

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

turt2live
Copy link
Member

No description provided.

@turt2live turt2live requested a review from a team July 25, 2019 20:54
@@ -28,5 +45,3 @@ Once enabled, send a custom state event to a room to set values:
```

That's it. Now should see your new counter under the header.

[#riot-web:matrix.org]: https://matrix.to/#/#riot-web:matrix.org
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a personal dislike for this style of link, so I've moved it.

@jryans jryans requested review from jryans and removed request for a team July 26, 2019 09:30
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😍 Thanks for doing this. I hope we'll remember to update this in a similar way for any future features.

@turt2live
Copy link
Member Author

I hope we'll remember to update this in a similar way for any future features.

I'm extremely tempted to make a CI job that scans for the string in this file when the features change in the react-sdk. For now though, let's hope our memory is sufficient ;)

@turt2live turt2live merged commit 11c0e98 into develop Jul 26, 2019
@turt2live turt2live deleted the travis/features branch July 26, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants