Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yarn start:https #16989

Merged
merged 4 commits into from
May 14, 2021
Merged

Add yarn start:https #16989

merged 4 commits into from
May 14, 2021

Conversation

SimonBrandner
Copy link
Contributor

FF and Chromium don't allow WebRTC without https if you're not connecting to localhost but sometimes you want to test WebRTC code with a different machine. This makes it possible

@SimonBrandner
Add yarn start:https
3c8efd5 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@t3chguy
Copy link
Member

t3chguy commented Apr 18, 2021

Doesn't webpack-dev-server by default forbid any non-local connections?

@SimonBrandner
Copy link
Contributor Author

Hmm, this worked for me.. Maybe we have it disabled

@SimonBrandner
Copy link
Contributor Author

Maybe we misunderstood each other. What did you mean by non-local connections? This should work only on LAN

@jryans
Copy link
Collaborator

jryans commented Apr 19, 2021 •
edited
Loading

Could we perhaps add $@ or whatever the right sigil is to start so that any extra options flow down to start:js, and then yarn start --https would work?

@SimonBrandner
Copy link
Contributor Author

Hmm, we should theoretically be able to use this but I am having trouble to get it working at the moment

@SimonBrandner
Copy link
Contributor Author

Upon further inspection, it seems that this would only work with npm. I am not sure what is the best path forwards here - does anyone else have any thoughts?

@t3chguy
Copy link
Member

t3chguy commented Apr 26, 2021

Hmm, this worked for me.. Maybe we have it disabled

I meant this

image

where webpack rejects unknown Hostnames if they are not e.g localhost or specified in the public property of the webpack config.

@t3chguy t3chguy mentioned this pull request May 7, 2021
Merged
@SimonBrandner
Copy link
Contributor Author

Upon further inspection, it seems that this would only work with npm. I am not sure what is the best path forwards here - does anyone else have any thoughts?

Unless there is a way to do this that I am missing, this PR seems to be the only way to do this

@t3chguy t3chguy requested a review from a team May 11, 2021 10:47
turt2live
turt2live approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure :D

@turt2live turt2live merged commit e716e48 into element-hq:develop May 14, 2021
@SimonBrandner SimonBrandner deleted the https branch May 14, 2021 05:44
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 6, 2021
@Midar
Update chat/element-web to 1.7.29
3136f70 
Changes in [1.7.29](https://github.com/vector-im/element-web/releases/tag/v1.7.29) (2021-05-24)
===============================================================================================
[Full Changelog](element-hq/element-web@v1.7.29-rc.1...v1.7.29)

## Security notice

Element Web 1.7.29 fixes (by upgrading to olm 3.2.3) an issue in code used for
decrypting server-side stored secrets. The issue could potentially allow a
malicious homeserver to cause a stack buffer overflow in the affected function
and to control that function's local variables.

## All changes

 * Upgrade to React SDK 3.22.0 and JS SDK 11.1.0
 * [Release] Bump libolm dependency, and update package name
   [\#17456](element-hq/element-web#17456)

Changes in [1.7.29-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.29-rc.1) (2021-05-19)
=========================================================================================================
[Full Changelog](element-hq/element-web@v1.7.28...v1.7.29-rc.1)

 * Upgrade to React SDK 3.22.0-rc.1 and JS SDK 11.1.0-rc.1
 * Translations update from Weblate
   [\#17384](element-hq/element-web#17384)
 * Prevent minification of `.html` files
   [\#17349](element-hq/element-web#17349)
 * Update matrix-widget-api/react-sdk dependency reference
   [\#17346](element-hq/element-web#17346)
 * Add `yarn start:https`
   [\#16989](element-hq/element-web#16989)
 * Translations update from Weblate
   [\#17239](element-hq/element-web#17239)
 * Remove "in development" flag from voice messages labs documentation
   [\#17204](element-hq/element-web#17204)
 * Add required webpack+jest config to load Safari support modules
   [\#17193](element-hq/element-web#17193)

Changes in [1.7.28](https://github.com/vector-im/element-web/releases/tag/v1.7.28) (2021-05-17)
===============================================================================================
[Full Changelog](element-hq/element-web@v1.7.28-rc.1...v1.7.28)

## Security notice

Element Web 1.7.28 fixes (by upgrading to matrix-react-sdk 3.21.0) a low
severity issue (GHSA-8796-gc9j-63rv) related to file upload. When uploading a
file, the local file preview can lead to execution of scripts embedded in the
uploaded file, but only after several user interactions to open the preview in
a separate tab. This only impacts the local user while in the process of
uploading. It cannot be exploited remotely or by other users. Thanks to
[Muhammad Zaid Ghifari](https://github.com/MR-ZHEEV) for responsibly disclosing
this via Matrix's Security Disclosure Policy.

## All changes

 * Upgrade to React SDK 3.21.0 and JS SDK 11.0.0

Changes in [1.7.28-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.28-rc.1) (2021-05-11)
=========================================================================================================
[Full Changelog](element-hq/element-web@v1.7.27...v1.7.28-rc.1)

 * Upgrade to React SDK 3.21.0-rc.1 and JS SDK 11.0.0-rc.1
 * Switch back to release version of `sanitize-html`
   [\#17231](element-hq/element-web#17231)
 * Bump url-parse from 1.4.7 to 1.5.1
   [\#17199](element-hq/element-web#17199)
 * Bump lodash from 4.17.20 to 4.17.21
   [\#17205](element-hq/element-web#17205)
 * Bump hosted-git-info from 2.8.8 to 2.8.9
   [\#17219](element-hq/element-web#17219)
 * Disable host checking on the webpack dev server
   [\#17194](element-hq/element-web#17194)
 * Bump ua-parser-js from 0.7.23 to 0.7.24
   [\#17190](element-hq/element-web#17190)

Changes in [1.7.27](https://github.com/vector-im/element-web/releases/tag/v1.7.27) (2021-05-10)
===============================================================================================
[Full Changelog](element-hq/element-web@v1.7.27-rc.1...v1.7.27)

 * Upgrade to React SDK 3.20.0 and JS SDK 10.1.0

Changes in [1.7.27-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.27-rc.1) (2021-05-04)
=========================================================================================================
[Full Changelog](element-hq/element-web@v1.7.26...v1.7.27-rc.1)

 * Upgrade to React SDK 3.20.0-rc.1 and JS SDK 10.1.0-rc.1
 * Translations update from Weblate
   [\#17160](element-hq/element-web#17160)
 * Document option for obeying asserted identity
   [\#17008](element-hq/element-web#17008)
 * Implement IPC call to Electron to set language
   [\#17052](element-hq/element-web#17052)
 * Convert Vector skin react components to Typescript
   [\#17061](element-hq/element-web#17061)
 * Add code quality review policy
   [\#16980](element-hq/element-web#16980)
 * Register RecorderWorklet from react-sdk
   [\#17013](element-hq/element-web#17013)
 * Preload Inter font to avoid FOIT on slow connections
   [\#17039](element-hq/element-web#17039)
 * Disable `postcss-calc`'s noisy `warnWhenCannotResolve` option
   [\#17041](element-hq/element-web#17041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimonBrandner @t3chguy @jryans @turt2live