New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make prequisites fixes for problems introduced in #726 #732

Merged

dmacvicar merged 1 commit into master from fix_726

May 5, 2021

Contributor

dmacvicar commented May 4, 2021 •

edited

Loading

Bad escape of variable in Makefile
Missing mod tidy to avoid a manual go get
Wrong package name in tools.go
Incorrect build tag in tools.go fixed in 5bcd041

This should fix the issue with goveralls


          fix: make prequisites fixes introduced in #726

00a507d

- Bad escape
- Missing mod tidy
- Wrong package name

Collaborator

coveralls commented May 4, 2021

Coverage remained the same at 87.018% when pulling 00a507d on fix_726 into 5bcd041 on master.

dmacvicar requested a review from jeroiraz

May 4, 2021 22:06

jeroiraz approved these changes

View reviewed changes

dmacvicar merged commit 76916b5 into master

byo deleted the fix_726 branch

October 14, 2022 10:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet