Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg/store): fixes issue #532 #549

Merged
merged 2 commits into from
Nov 19, 2020
Merged

fix(pkg/store): fixes issue #532 #549

merged 2 commits into from
Nov 19, 2020

Conversation

jeroiraz
Copy link
Contributor

Fixes issues #532

Signed-off-by: Jeronimo Irazabal jeronimo.irazabal@gmail.com

Signed-off-by: Jeronimo Irazabal <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo Irazabal <jeronimo.irazabal@gmail.com>
@jeroiraz jeroiraz marked this pull request as ready for review November 19, 2020 12:29
@jeroiraz jeroiraz closed this Nov 19, 2020
@jeroiraz jeroiraz reopened this Nov 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #549 (593ce06) into master (3bbaafe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #549   +/-   ##
=======================================
  Coverage   58.43%   58.43%           
=======================================
  Files         148      148           
  Lines       11507    11501    -6     
=======================================
- Hits         6724     6721    -3     
+ Misses       4248     4246    -2     
+ Partials      535      534    -1     
Impacted Files Coverage Δ
pkg/store/treestore.go 81.30% <ø> (ø)
pkg/store/store.go 80.74% <100.00%> (+0.20%) ⬆️
pkg/server/corruption_checker.go 89.04% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bbaafe...593ce06. Read the comment docs.

@jeroiraz jeroiraz merged commit e213d56 into master Nov 19, 2020
@jeroiraz jeroiraz deleted the fix_532 branch November 19, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dump does not export entries (even if db is not empty) if no *set command has been issued since immudb start
3 participants