Skip to content

Commit fc4c86c

Browse files
committed
Fix a accumulating error
1 parent 6ae95b5 commit fc4c86c

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

README.md

+1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ Alternative way to build the plugin is using `build` shell script
6969
- add list of order / items
7070
- fix NaN issue on Amazon content page
7171
- add link to github project
72+
- fix a accumulating error
7273

7374
## License
7475

src/primary/components/Page.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ class Page extends Component {
102102
<Menu fixed='bottom' inverted>
103103
<Container text>
104104
<Menu.Item href='https://github.com/vasyaod/abc/issues'>
105-
<Icon name='github'/> Report issue on Github
105+
<Icon name='github'/> Issues?
106106
</Menu.Item>
107107
<Menu.Item color='facebook' onClick={this.props.shareFacebook}>
108108
<Icon name='facebook'/> Share on Facebook

src/primary/reducers.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ export function todoApp(state = initialState, action) {
112112
var date = new Date();
113113
var firstDayOfPreviousMonth = new Date(date.getFullYear(), date.getMonth() - month - 1, 1);
114114
var firstDayTheMonth = new Date(date.getFullYear(), date.getMonth() - month, 1);
115-
return firstDayTheMonth.getTime() >= x.orderDate.getTime() && firstDayOfPreviousMonth.getTime() <= x.orderDate.getTime()
115+
return firstDayTheMonth.getTime() > x.orderDate.getTime() && firstDayOfPreviousMonth.getTime() <= x.orderDate.getTime()
116116
})
117117
.map(x => x.amount)
118118
.reduce((prev, current) => prev + current, 0.0)
@@ -146,7 +146,7 @@ export function todoApp(state = initialState, action) {
146146
var date = new Date();
147147
var firstDayOfPreviousMonth = new Date(date.getFullYear(), date.getMonth() - month, 1);
148148
var firstDayTheMonth = new Date(date.getFullYear(), date.getMonth() - month + 1, 1);
149-
return firstDayTheMonth.getTime() >= x.orderDate.getTime() && firstDayOfPreviousMonth.getTime() <= x.orderDate.getTime()
149+
return firstDayTheMonth.getTime() > x.orderDate.getTime() && firstDayOfPreviousMonth.getTime() <= x.orderDate.getTime()
150150
})
151151
.map(x => x.amount)
152152
.reduce((prev, current) => prev + current, 0.0)

src/reducer-utils.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export function previousMonth(orders) {
1717
var date = new Date();
1818
var firstDayOfPreviousMonth = new Date(date.getFullYear(), date.getMonth() - 1, 1);
1919
var firstDayTheMonth = new Date(date.getFullYear(), date.getMonth(), 1);
20-
return firstDayTheMonth.getTime() >= x.orderDate.getTime() && firstDayOfPreviousMonth.getTime() <= x.orderDate.getTime()
20+
return firstDayTheMonth.getTime() > x.orderDate.getTime() && firstDayOfPreviousMonth.getTime() <= x.orderDate.getTime()
2121
})
2222
.map(x => x.amount)
2323
.reduce((prev, current) => prev + current, 0.0)
@@ -42,7 +42,7 @@ export function previousYear(orders) {
4242
var date = new Date();
4343
var firstDayOfPreviousMonth = new Date(date.getFullYear() - 1, 0, 1);
4444
var firstDayTheMonth = new Date(date.getFullYear(), 0, 1);
45-
return firstDayTheMonth.getTime() >= x.orderDate.getTime() && firstDayOfPreviousMonth.getTime() <= x.orderDate.getTime()
45+
return firstDayTheMonth.getTime() > x.orderDate.getTime() && firstDayOfPreviousMonth.getTime() <= x.orderDate.getTime()
4646
})
4747
.map(x => x.amount)
4848
.reduce((prev, current) => prev + current, 0.0)

0 commit comments

Comments
 (0)