Skip to content
This repository was archived by the owner on Jun 14, 2024. It is now read-only.

Stabilize and normalize 13/WAKU2-STORE RFC #552

Closed
5 tasks
Tracked by #528
LNSD opened this issue Nov 9, 2022 · 4 comments
Closed
5 tasks
Tracked by #528

Stabilize and normalize 13/WAKU2-STORE RFC #552

LNSD opened this issue Nov 9, 2022 · 4 comments
Assignees
Labels
track:waku-specs Waku specs track (RAD)

Comments

@LNSD
Copy link
Contributor

LNSD commented Nov 9, 2022

Problem

From #528:

The protocols specified in the following RFCs are ready for the stable status:

Acceptance criteria

  • Make the RFC conform to the RFC template
  • Add the new protocol's wire format (v3) to the waku store RFC. Deprecate v2-beta4
  • Merged 21/WAKU2-FAULT-TOLERANT-STORE's wire specification into 13/WAKU2-STORE
  • Add current Waku Store protobuf definitions to the waku protobuf repository (v2-alpha4)
  • Add the new Waku Store protobuf version(v3)

Notes

This task has a dependency on #551

@LNSD LNSD added the track:waku-specs Waku specs track (RAD) label Nov 9, 2022
@LNSD LNSD self-assigned this Nov 9, 2022
@staheri14
Copy link
Contributor

staheri14 commented Nov 16, 2022

Merged 21/WAKU2-FAULT-TOLERANT-STORE's wire specification into 13/WAKU2-STORE

Regarding the above item, I would suggest to get an agreement before attempting it. The separation of these two RFCs was intentional. Since the time query feature was emerged from the need to make store protocol fault-tolerant against nodes with poor connectivity, the decision was to capture the problem together with the solution in a separate specification. Potentially, this specification i.e., FT-Store can evolve and include more solutions for handling faulty nodes.

Update: Is my interpretation of this task correct? do you want to merge them? or just include the start_time and end_time fields in the HistoryQuery protobuf definition?

@jm-clius
Copy link
Contributor

The separation of these two RFCs was intentional.

Indeed! The two RFCs must remain separate. This task is simply to include the start_time and end_time fields in the general Store protobuf definitions. :)
This is so we can stabilise STORE which is being used widely with the time fields (e.g. by Status) without having to also stabilise FT-STORE (which will remain separate and in draft).

Is my interpretation of this task correct? do you want to merge them? or just include the start_time and end_time fields in the HistoryQuery protobuf definition?

The latter 😄 . FT-STORE must remain its own spec.

@LNSD LNSD changed the title Promote 13/WAKU2-STORE RFC to stable state Stabilize and normalize 13/WAKU2-STORE RFC Nov 28, 2022
@LNSD
Copy link
Contributor Author

LNSD commented Nov 28, 2022

The Waku store v3 wire format has been sketched in the following draft PR: waku-org/waku-proto#10

@jimstir
Copy link
Contributor

jimstir commented Jun 13, 2024

Closing as it seems discussion is complete.

@jimstir jimstir closed this as completed Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
track:waku-specs Waku specs track (RAD)
Projects
None yet
Development

No branches or pull requests

4 participants