Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation hook in Floodsub and Gossipsub #43

Closed
dryajov opened this issue Dec 6, 2019 · 1 comment
Closed

Add validation hook in Floodsub and Gossipsub #43

dryajov opened this issue Dec 6, 2019 · 1 comment
Labels
good first issue Good for newcomers missing feature

Comments

@dryajov
Copy link
Contributor

dryajov commented Dec 6, 2019 •
edited
Loading

The current implementation is missing a validation hook that would allow validating and messages. If validation succeeds then the message would be further propagated, if not, the message is dropped and the peer potentially blacklisted. This needs to comply with spec and the Go reference implementation.
@dryajov dryajov added enhancement New feature or request missing feature good first issue Good for newcomers and removed enhancement New feature or request labels Dec 6, 2019
@dryajov
Copy link
Contributor Author

dryajov commented Jan 23, 2020

Closed by #58

@dryajov dryajov closed this as completed Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers missing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dryajov