Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browserify --bare cause global is undefined in browser environemnt #172

Closed
fbuecklers opened this issue Jan 6, 2017 · 1 comment
Closed

Comments

@fbuecklers
Copy link

Hi,

is there any reason, why rng-browser.js use global explicitly?
We create a browserify --bare bundle which do not inject the global variable which breaks our browserify bundle.

Isn't it better to just test crypto availability with typeof and use it directly? Therefore the global access is made implicitly which works well in browser and in node environments.

Thanks!
Florian

@broofa
Copy link
Member

broofa commented Sep 11, 2017

Fixed in #221

@broofa broofa closed this as completed Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants