Merge pull request #4027 from ustaxcourt/staging

Merging staging into prod

Author: jimlerza

.circleci/config.yml

@@ -1,7 +1,8 @@
 version: 2.1
 orbs:
   git-shallow-clone: guitarrapc/git-shallow-clone@2.6.0
-define: &efcms-docker-image $AWS_ACCOUNT_ID.dkr.ecr.us-east-1.amazonaws.com/ef-cms-us-east-1:3.0.14
+
+efcms-docker-image: &efcms-docker-image $AWS_ACCOUNT_ID.dkr.ecr.us-east-1.amazonaws.com/ef-cms-us-east-1:3.0.15
 
 parameters:
   run_build_and_deploy:
@@ -29,15 +30,15 @@ parameters:
     type: boolean
 
   referrer:
-    default: ""
+    default: ''
     type: string
 
   source_bucket:
-    default: ""
+    default: ''
     type: string
 
   destination_bucket:
-    default: ""
+    default: ''
     type: string
 
 commands:
@@ -955,7 +956,7 @@ workflows:
   glue-to-test:
     when:
       or:
-        - equal: [ glue-to-test-schedule, << pipeline.schedule.name >> ]
+        - equal: [glue-to-test-schedule, << pipeline.schedule.name >>]
         - << pipeline.parameters.run_glue_to_test >>
     jobs:
       - delete-existing-data:

Dockerfile

@@ -37,7 +37,7 @@ RUN apt-get install -y build-essential
 RUN apt-get install -y libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev
 
 ENV JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64
-RUN curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-2.13.17.zip" -o "awscliv2.zip" && \
+RUN curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-2.13.20.zip" -o "awscliv2.zip" && \
   unzip awscliv2.zip && \
   ./aws/install && \
   rm -rf awscliv2.zip

docs/dependency-updates.md

@@ -67,16 +67,17 @@ Below is a list of dependencies that are locked down due to known issues with se
 
 - Keep `@sparticuz/chromium` locked to 112.0.2 and `puppeteer` locked to 19.8.5 as 114+ and 20+ were causing pdf generation timeout bugs. (https://app.zenhub.com/workspaces/flexionef-cms-5bbe4bed4b5806bc2bec65d3/issues/gh/flexion/ef-cms/10087).
 
-- When updating puppeteer or puppeteer core in the project make sure to also match versions in web-api/runtimes/puppeteer/package.json as this is our lambda layer which we use to generate pdfs. Puppeteer and chromium versions should always match between package.json and web-api/runtimes/puppeteer/package.json.  Remember to run `npm i` after updating the versions to update the package-lock.json.
+- When updating puppeteer or puppeteer core in the project, make sure to also match versions in `web-api/runtimes/puppeteer/package.json` as this is our lambda layer which we use to generate pdfs. Puppeteer and chromium versions should always match between package.json and web-api/runtimes/puppeteer/package.json.  Remember to run `npm i` after updating the versions to update the package-lock.json.
 
 #### s3rver
 - As of 7/26/2023 there is a high security vulnerability for transitive dependency in s3rver for "fast-xml-parser". This cannot be fixed using the patch method above as it is a dependency of a dependency. Currently waiting for pull request to update fast-xml parser dependency(https://github.com/jamhall/s3rver/pull/813).
 - The s3rver package has been abandoned for two years now and is unlikely to be fixed. A community member has forked the repo and fixed the vulnerabilities so we are switching to the forked version here: github:20minutes/s3rver (https://github.com/20minutes/s3rver). This means the s3rver community version is unlikely to be updated however, the original npm package has been abandoned for over 2 years.
 
 ### pdfjs-dist
 
-- `pdfjs-dist` has a major version update to ^3.x,x. A devex card has been created to track work being done towards updating. Please add notes and comments to [this card](https://trello.com/c/gjDzhUkb/1111-upgrade-pdfjs-dist).
+- `pdfjs-dist` has a major version update to ^3.x,x. A devex card has been created to track work being done towards updating the package. Please add notes and comments to [this card](https://trello.com/c/gjDzhUkb/1111-upgrade-pdfjs-dist).
 
 ### Incrementing the Node Cache Key Version
 
-It's rare to need to increment or change the cache key. One reason you may want to do so is if something happens while storing the cache which corrupts it. For example, a few months ago a package failed to install while the cache was being stored. CircleCI had no idea that the installation didn't go according to plan and saved the corrupted cache. In this case, we incremented the cache key version so that CircleCI was forced to reinstall the node dependencies and save them under the new key. The cache key can be updated by searching within config.yml for vX-npm and vX-cypress where X is the current version of the cache key, then increment the version found.
+It's rare to need modify cache key. One reason you may want to do so is if a package fails to install properly, and CircleCI, unaware of the failed installation, stores the corrupted cache. In this case, we will need to increment the cache key version so that CircleCI is forced to reinstall the node dependencies and save them using the new key. To update the cache key, locate `vX-npm` and `vX-cypress` (where X represents the current cache key version) in the config.yml file, and then increment the identified version.
+

docs/testing.md

@@ -170,7 +170,7 @@ The scripts containing the word `readonly` run special smoketests that rely on e
 
 #### Open
 
-The Cypress CLI runner also provides a useful `open` command which will load a browser instance locally which developers can use to watch the tests click through the UI and rewind history.
+The Cypress CLI runner also provides a useful `open` command which will load a browser instance locally, which developers can use to watch the tests click through the UI and rewind history.
 
 #### Public
 

iam/terraform/account-specific/main/main.tf

@@ -17,6 +17,6 @@ terraform {
   }
 
   required_providers {
-    aws = "5.16.1"
+    aws = "5.17.0"
   }
 }

iam/terraform/environment-specific/main/main.tf

@@ -7,6 +7,6 @@ terraform {
   }
 
   required_providers {
-    aws = "5.16.1"
+    aws = "5.17.0"
   }
 }