Skip to content

Commit 825661a

Browse files
jimlerzajimlerza
authored
Merge pull request #2689 from flexion/3569-remove-feature-flag
3569: Remove feature flag
2 parents e59b24b + 22c8c12 commit 825661a

23 files changed

+48
-391
lines changed

‎scripts/dynamo/delete-consolidated-cases-propagate-docket-entries.sh

+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
#!/bin/bash
2+
3+
# Deletes the consolidated case docket entry duplication enabled feature flag
4+
# Usage
5+
# ENV=dev ./scripts/dynamo/delete-consolidated-cases-propagate-docket-entries.sh
6+
7+
./check-env-variables.sh \
8+
"ENV" \
9+
"AWS_SECRET_ACCESS_KEY" \
10+
"AWS_ACCESS_KEY_ID"
11+
12+
aws dynamodb delete-item --region us-east-1 --table-name "efcms-deploy-${ENV}" --key '{"pk":{"S":"consolidated-cases-propagate-docket-entries"},"sk":{"S":"consolidated-cases-propagate-docket-entries"}}'

‎scripts/dynamo/setup-consolidated-cases-propagate-docket-entries.sh

-13
This file was deleted.

‎scripts/setup-all-env-configuration.sh

-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,5 @@
1919
./scripts/dynamo/setup-terminal-ip-allowlist.sh
2020
./scripts/dynamo/setup-maintenance-mode-flag.sh
2121
./scripts/dynamo/setup-section-outbox-retrieval-days.sh
22-
./scripts/dynamo/setup-consolidated-cases-propagate-docket-entries.sh
2322
./scripts/dynamo/enable-stamp-disposition.sh
2423
./scripts/dynamo/setup-add-docket-numbers-to-orders-flag.sh

‎shared/src/business/entities/EntityConstants.js

-5
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,6 @@ const ALLOWLIST_FEATURE_FLAGS = {
6262
'The ability to add multiple docket entries to an order is disabled.',
6363
key: 'consolidated-cases-add-docket-numbers',
6464
},
65-
CONSOLIDATED_CASES_PROPAGATE_DOCKET_ENTRIES: {
66-
disabledMessage:
67-
'Docket entries are not being duplicated across consolidated cases temporarily.',
68-
key: 'consolidated-cases-propagate-docket-entries',
69-
},
7065
EXTERNAL_OPINION_SEARCH: {
7166
disabledMessage:
7267
'Opinion search has been temporarily disabled. Please try again later.',

‎shared/src/business/useCases/courtIssuedDocument/fileAndServeCourtIssuedDocumentInteractor.consolidatedCases.test.ts

+7-40
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
1-
import {
2-
applicationContext,
3-
testPdfDoc,
4-
} from '../../test/createTestApplicationContext';
1+
import { Case } from '../../entities/cases/Case';
52
import {
63
DOCKET_SECTION,
74
TRANSCRIPT_EVENT_CODE,
85
} from '../../entities/EntityConstants';
96
import { ENTERED_AND_SERVED_EVENT_CODES } from '../../entities/courtIssuedDocument/CourtIssuedDocumentConstants';
10-
import { fileAndServeCourtIssuedDocumentInteractor } from './fileAndServeCourtIssuedDocumentInteractor';
117
import {
128
MOCK_CONSOLIDATED_1_CASE_WITH_PAPER_SERVICE,
139
MOCK_CONSOLIDATED_2_CASE_WITH_PAPER_SERVICE,
1410
MOCK_LEAD_CASE_WITH_PAPER_SERVICE,
1511
} from '../../../test/mockCase';
16-
import { Case } from '../../entities/cases/Case';
12+
import { MOCK_DOCUMENTS } from '../../../test/mockDocuments';
13+
import {
14+
applicationContext,
15+
testPdfDoc,
16+
} from '../../test/createTestApplicationContext';
1717
import { cloneDeep } from 'lodash';
1818
import { docketClerkUser } from '../../../test/mockUsers';
19-
import { MOCK_DOCUMENTS } from '../../../test/mockDocuments';
19+
import { fileAndServeCourtIssuedDocumentInteractor } from './fileAndServeCourtIssuedDocumentInteractor';
2020
import { v4 as uuidv4 } from 'uuid';
2121

2222
describe('consolidated cases', () => {
@@ -78,11 +78,6 @@ describe('consolidated cases', () => {
7878
}),
7979
});
8080

81-
// CONSOLIDATED_CASES_PROPAGATE_DOCKET_ENTRIES
82-
applicationContext
83-
.getUseCases()
84-
.getFeatureFlagValueInteractor.mockReturnValue(Promise.resolve(true));
85-
8681
leadCaseDocketEntries = [
8782
mockDocketEntryWithWorkItem,
8883
{
@@ -406,32 +401,4 @@ describe('consolidated cases', () => {
406401
applicationContext.getPersistenceGateway().saveDocumentFromLambda,
407402
).toHaveBeenCalledTimes(1);
408403
});
409-
410-
// CONSOLIDATED_CASES_PROPAGATE_DOCKET_ENTRIES
411-
it('should only process the subject case when the feature flag is disabled and there are other consolidated cases', async () => {
412-
applicationContext
413-
.getUseCases()
414-
.getFeatureFlagValueInteractor.mockReturnValueOnce(
415-
Promise.resolve(false),
416-
);
417-
418-
await fileAndServeCourtIssuedDocumentInteractor(applicationContext, {
419-
clientConnectionId,
420-
docketEntryId: leadCaseDocketEntries[0].docketEntryId,
421-
docketNumbers: [
422-
MOCK_LEAD_CASE_WITH_PAPER_SERVICE.docketNumber,
423-
MOCK_CONSOLIDATED_1_CASE_WITH_PAPER_SERVICE.docketNumber,
424-
MOCK_CONSOLIDATED_2_CASE_WITH_PAPER_SERVICE.docketNumber,
425-
],
426-
form: leadCaseDocketEntries[0],
427-
subjectCaseDocketNumber: MOCK_LEAD_CASE_WITH_PAPER_SERVICE.docketNumber,
428-
});
429-
430-
expect(
431-
applicationContext.getUseCaseHelpers().updateCaseAndAssociations,
432-
).toHaveBeenCalledTimes(1);
433-
434-
expect(updateDocketEntrySpy).toHaveBeenCalledTimes(1);
435-
expect(addDocketEntrySpy).toHaveBeenCalledTimes(0);
436-
});
437404
});

‎shared/src/business/useCases/courtIssuedDocument/fileAndServeCourtIssuedDocumentInteractor.ts

+2-14
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
import {
2-
ALLOWLIST_FEATURE_FLAGS,
3-
DOCKET_SECTION,
4-
} from '../../entities/EntityConstants';
51
import { Case } from '../../entities/cases/Case';
2+
import { DOCKET_SECTION } from '../../entities/EntityConstants';
63
import { DocketEntry } from '../../entities/DocketEntry';
74
import {
85
ENTERED_AND_SERVED_EVENT_CODES,
@@ -70,17 +67,8 @@ export const fileAndServeCourtIssuedDocumentInteractor = async (
7067

7168
const eventCodeCanOnlyBeServedOnSubjectCase =
7269
ENTERED_AND_SERVED_EVENT_CODES.includes(form.eventCode);
73-
const consolidateCaseDuplicateDocketEntries = await applicationContext
74-
.getUseCases()
75-
.getFeatureFlagValueInteractor(applicationContext, {
76-
featureFlag:
77-
ALLOWLIST_FEATURE_FLAGS.CONSOLIDATED_CASES_PROPAGATE_DOCKET_ENTRIES.key,
78-
});
7970

80-
if (
81-
eventCodeCanOnlyBeServedOnSubjectCase ||
82-
!consolidateCaseDuplicateDocketEntries
83-
) {
71+
if (eventCodeCanOnlyBeServedOnSubjectCase) {
8472
docketNumbers = [subjectCaseDocketNumber];
8573
}
8674

‎shared/src/business/useCases/courtIssuedDocument/serveCourtIssuedDocumentInteractor.consolidatedCases.test.ts

-31
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,6 @@ describe('serveCourtIssuedDocumentInteractor consolidated cases', () => {
7777
}),
7878
});
7979

80-
// CONSOLIDATED_CASES_PROPAGATE_DOCKET_ENTRIES
81-
applicationContext
82-
.getUseCases()
83-
.getFeatureFlagValueInteractor.mockReturnValue(Promise.resolve(true));
84-
8580
leadCaseDocketEntries = [
8681
mockDocketEntryWithWorkItem,
8782
{
@@ -404,30 +399,4 @@ describe('serveCourtIssuedDocumentInteractor consolidated cases', () => {
404399
applicationContext.getPersistenceGateway().saveDocumentFromLambda,
405400
).toHaveBeenCalledTimes(1);
406401
});
407-
408-
// CONSOLIDATED_CASES_PROPAGATE_DOCKET_ENTRIES
409-
it('should only process the subject case when the feature flag is disabled and there are other consolidated cases', async () => {
410-
applicationContext
411-
.getUseCases()
412-
.getFeatureFlagValueInteractor.mockReturnValueOnce(
413-
Promise.resolve(false),
414-
);
415-
416-
await serveCourtIssuedDocumentInteractor(applicationContext, {
417-
clientConnectionId,
418-
docketEntryId: leadCaseDocketEntries[0].docketEntryId,
419-
docketNumbers: [
420-
MOCK_LEAD_CASE_WITH_PAPER_SERVICE.docketNumber,
421-
MOCK_CONSOLIDATED_1_CASE_WITH_PAPER_SERVICE.docketNumber,
422-
MOCK_CONSOLIDATED_2_CASE_WITH_PAPER_SERVICE.docketNumber,
423-
],
424-
subjectCaseDocketNumber: MOCK_LEAD_CASE_WITH_PAPER_SERVICE.docketNumber,
425-
});
426-
427-
expect(
428-
applicationContext.getUseCaseHelpers().updateCaseAndAssociations,
429-
).toHaveBeenCalledTimes(1);
430-
431-
expect(addDocketEntrySpy).toHaveBeenCalledTimes(0);
432-
});
433402
});

‎shared/src/business/useCases/courtIssuedDocument/serveCourtIssuedDocumentInteractor.ts

+2-14
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
import {
2-
ALLOWLIST_FEATURE_FLAGS,
3-
DOCKET_SECTION,
4-
} from '../../entities/EntityConstants';
51
import { Case } from '../../entities/cases/Case';
2+
import { DOCKET_SECTION } from '../../entities/EntityConstants';
63
import { DocketEntry } from '../../entities/DocketEntry';
74
import {
85
ENTERED_AND_SERVED_EVENT_CODES,
@@ -135,17 +132,8 @@ export const serveCourtIssuedDocumentInteractor = async (
135132

136133
const eventCodeCanOnlyBeServedOnSubjectCase =
137134
ENTERED_AND_SERVED_EVENT_CODES.includes(courtIssuedDocument.eventCode);
138-
const consolidateCaseDuplicateDocketEntries = await applicationContext
139-
.getUseCases()
140-
.getFeatureFlagValueInteractor(applicationContext, {
141-
featureFlag:
142-
ALLOWLIST_FEATURE_FLAGS.CONSOLIDATED_CASES_PROPAGATE_DOCKET_ENTRIES.key,
143-
});
144135

145-
if (
146-
eventCodeCanOnlyBeServedOnSubjectCase ||
147-
!consolidateCaseDuplicateDocketEntries
148-
) {
136+
if (eventCodeCanOnlyBeServedOnSubjectCase) {
149137
docketNumbers = [subjectCaseDocketNumber];
150138
}
151139

‎shared/src/business/useCases/generateCoverSheetData.ts

+3-10
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {
33
COURT_ISSUED_EVENT_CODES_REQUIRING_COVERSHEET,
44
} from '../entities/EntityConstants';
55
import { Case } from '../entities/cases/Case';
6-
import { formatDateString, FORMATS } from '../utilities/DateHandler';
6+
import { FORMATS, formatDateString } from '../utilities/DateHandler';
77
import { omit } from 'lodash';
88

99
const formatDateReceived = ({ docketEntryEntity, isPaper }) => {
@@ -112,15 +112,8 @@ export const generateCoverSheetData = async ({
112112
]);
113113

114114
const isLeadCase = caseEntity.leadDocketNumber === caseEntity.docketNumber;
115-
const isFeatureFlagEnabled = await applicationContext
116-
.getUseCases()
117-
.getFeatureFlagValueInteractor(applicationContext, {
118-
featureFlag:
119-
ALLOWLIST_FEATURE_FLAGS.CONSOLIDATED_CASES_PROPAGATE_DOCKET_ENTRIES
120-
.key,
121-
});
122-
123-
if (isLeadCase && isFeatureFlagEnabled) {
115+
116+
if (isLeadCase) {
124117
const consolidatedCases = await applicationContext
125118
.getPersistenceGateway()
126119
.getCasesByLeadDocketNumber({

‎web-api/storage/fixtures/seed/efcms-local.json

-5
Original file line numberDiff line numberDiff line change
@@ -4686,11 +4686,6 @@
46864686
"current": true,
46874687
"pk": "internal-opinion-search-enabled"
46884688
},
4689-
{
4690-
"pk": "consolidated-cases-propagate-docket-entries",
4691-
"sk": "consolidated-cases-propagate-docket-entries",
4692-
"current": true
4693-
},
46944689
{
46954690
"pk": "consolidated-cases-add-docket-numbers",
46964691
"sk": "consolidated-cases-add-docket-numbers",

‎web-client/integration-tests/docketClerkConsolidatesCases.test.js

+1-12
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,7 @@ import { docketClerkServesDocumentOnLeadCase } from './journey/docketClerkServes
1010
import { docketClerkSignsOrder } from './journey/docketClerkSignsOrder';
1111
import { docketClerkUnconsolidatesLeadCase } from './journey/docketClerkUnconsolidatesLeadCase';
1212
import { docketClerkUpdatesCaseStatusToReadyForTrial } from './journey/docketClerkUpdatesCaseStatusToReadyForTrial';
13-
import {
14-
loginAs,
15-
setConsolidatedCasesPropagateEntriesFlag,
16-
setupTest,
17-
uploadPetition,
18-
} from './helpers';
13+
import { loginAs, setupTest, uploadPetition } from './helpers';
1914
import { petitionerVerifiesConsolidatedCases } from './journey/petitionerVerifiesConsolidatedCases';
2015
import { petitionerVerifiesUnconsolidatedCases } from './journey/petitionerVerifiesUnconsolidatedCases';
2116
import { petitionerViewsDashboard } from './journey/petitionerViewsDashboard';
@@ -35,7 +30,6 @@ describe('Case Consolidation Journey', () => {
3530
});
3631

3732
afterAll(async () => {
38-
await setConsolidatedCasesPropagateEntriesFlag(true);
3933
cerebralTest.closeSocket();
4034
});
4135

@@ -199,11 +193,6 @@ describe('Case Consolidation Journey', () => {
199193
cerebralTest.consolidatedCasesThatShouldReceiveDocketEntries = [];
200194
});
201195

202-
// CONSOLIDATED_CASES_PROPAGATE_DOCKET_ENTRIES
203-
it('should set the feature flag to false', async () => {
204-
await setConsolidatedCasesPropagateEntriesFlag(false);
205-
});
206-
207196
docketClerkCreatesAnOrder(cerebralTest, {
208197
documentTitle: 'Order to do something only on the lead case',
209198
eventCode: 'O',

‎web-client/integration-tests/helpers.js

+2-13
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,8 @@ import qs from 'qs';
7373
import riotRoute from 'riot-route';
7474
import sass from 'sass';
7575

76-
const {
77-
ALLOWLIST_FEATURE_FLAGS,
78-
CASE_TYPES_MAP,
79-
PARTY_TYPES,
80-
SERVICE_INDICATOR_TYPES,
81-
} = applicationContext.getConstants();
76+
const { CASE_TYPES_MAP, PARTY_TYPES, SERVICE_INDICATOR_TYPES } =
77+
applicationContext.getConstants();
8278

8379
const formattedDocketEntries = withAppContextDecorator(
8480
formattedDocketEntriesComputed,
@@ -391,13 +387,6 @@ export const setOrderSearchEnabled = async (isEnabled, keyPrefix) => {
391387
return await setFeatureFlag(isEnabled, `${keyPrefix}-order-search-enabled`);
392388
};
393389

394-
export const setConsolidatedCasesPropagateEntriesFlag = async isEnabled => {
395-
return await setFeatureFlag(
396-
isEnabled,
397-
ALLOWLIST_FEATURE_FLAGS.CONSOLIDATED_CASES_PROPAGATE_DOCKET_ENTRIES.key,
398-
);
399-
};
400-
401390
export const setFeatureFlag = async (isEnabled, key) => {
402391
return await client.put({
403392
Item: {

‎web-client/src/presenter/actions/CourtIssuedDocketEntry/fileAndServeCourtIssuedDocumentAction.js

-5
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,12 @@ export const fileAndServeCourtIssuedDocumentAction = async ({
3232

3333
const consolidatedCases = get(state.caseDetail.consolidatedCases) || [];
3434

35-
const consolidatedCasesPropagateDocketEntriesFlag = get(
36-
state.featureFlagHelper.consolidatedCasesPropagateDocketEntries,
37-
);
38-
3935
let docketNumbers = consolidatedCases
4036
.filter(consolidatedCase => consolidatedCase.checked)
4137
.map(consolidatedCase => consolidatedCase.docketNumber);
4238

4339
if (
4440
!isLeadCase ||
45-
!consolidatedCasesPropagateDocketEntriesFlag ||
4641
docketNumbers.length === 0 ||
4742
!currentDocketEntryCompatibleWithConsolidation
4843
) {

0 commit comments

Comments
 (0)