Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completing Pages site for RC #332

Closed
wendellpiez opened this issue Mar 20, 2019 · 13 comments
Closed

Completing Pages site for RC #332

wendellpiez opened this issue Mar 20, 2019 · 13 comments
Assignees
Labels
Scope: Website Issues targeted at the OSCAL project website. User Story

Comments

@wendellpiez
Copy link
Contributor

User Story:

As an OSCAL user, I need to find information on OSCAL on the web site. For the Release Candidate, the site needs to be as good as we can make it.

Goals:

In meeting with Jim Foti (NIST) we captured the following excellent suggestions:

  • All pages should have a side navigation panel for visual consistency and ease of use.
  • In general, the top of the side navigation should indicate the page being shown in context, that is, within the same structure as it indicated by site navigation (top nav bar).
  • Some of these pages would also benefit from navigation on the page with links to the h2 and h3 headers (there must be a Liquid filter for this).
  • The "Learn More" pages are especially scant. They need examples or links to examples.
  • Pages, especially time-sensitive pages such as "News", should have a line at the bottom indicating the date last modified.
  • Also, these items should be reverse-chrono ordered.
  • And kept up to date (we need a maintenance model).
  • Search is not working on the Preview site. Maybe this needs its own Issue? Clicking the Search button results only in its disappearance.

We need to triage this set of issues, add any that are newly uncovered, and complete any that are determined to be in scope for this effort (probably most of them).

Simultaneously, we are conducting an internal review at NIST looking at all the content for accuracy and clarity.

Dependencies:

This Issue picks up from #311, which can be closed.

Additionally, these edits will be easier to make if #286 and #314 are complete and integrated.

Acceptance Criteria

  1. All revisions and improvements we can make, have been made
  2. We are tracking any revisions and improvements staged for later
@wendellpiez
Copy link
Contributor Author

Comparing to our site, the USWDS demo site is interesting: https://designsystem.digital.gov/documentation/

Note:

  • USWDS has no Search
  • Top level nav is only one level. Lower levels are linked only from side panel navigation. Link in, and the side navigation extends (dynamically). This arrangement helps with the problem noted above, that side navigation is inconsistent and hard to trace.

@wendellpiez
Copy link
Contributor Author

Progress March 27 2018

Having received comments from our internal review, I have made many changes to the site and have notes on more changes to be made.

These need to be captured and organized into a set of tasks and/or questions.

@iMichaela
Copy link
Contributor

03/28/2019

With help from Jim Foti, @wendellpiez made initial updates. We have more to update and we will also need some input from @david-waltermire-nist. The navigation needs to be restructured. @wendellpiez and @anweiss will meet to make the changes. @wendellpiez will add the list of requirements from Jim here.

@wendellpiez
Copy link
Contributor Author

The goals list above presents an initial punchlist of the items called out by Jim (and not yet done).

I also have a more detailed list including many potential enhancements to content. However, these also depend on changes to structure. @anweiss and I will communicate on how best to expedite this.

@wendellpiez
Copy link
Contributor Author

Noting that today's preview has broken links on the "Community" page. These will be fixed with restructuring underway.

@wendellpiez
Copy link
Contributor Author

wendellpiez commented Apr 4, 2019

Progress April 4 2019

Current preview here: http://nist-oscal.s3-website-us-east-1.amazonaws.com/

Most of the changes being tracked above have been made.

Remaining (not an exclusive list):

  • Some inconsistencies between page names, headers and sidenavs to be ironed out
  • Need to plan for maintenance of time-sensitive pages
    • Show dates including "last modified" date for page
    • Track in reverse-chrono order
  • Search is not working; must discuss (uswds?)
  • "Community" pages - they say who they are, but not what they should do or how they can help
  • "Components" pages - must be more complete and tied to the actual architecture of OSCAL - how this relates to the layered schemas
  • "Learn More" pages
  • Schema docs - much work to do
    • Better navigation?
    • Separate remarks for JSON and XML?
    • Top-level pages for each model with strategic view (markdown, not pulled from the metaschema)

Suggest we make separate issues for these and close this one.

@brian-ruf
Copy link
Contributor

4/4/2019 - @anweiss to point to instructions so he and @david-waltermire-nist can setup search on 4/5.
See #314 for other follow-up actions.

@iMichaela
Copy link
Contributor

04/11/2019

NIST advised the team to embed Google analytics. Waiting for the code. Otherwise, the pages are ready for the first release followed by next editing cycle in the next Sprint.

@david-waltermire
Copy link
Contributor

4-19-19

@david-waltermire-nist will verify that these are addressed in the PR and will work with @wendellpiez and @anweiss to correct any remaining issues (e.g., add google analytics). One this is done, we can close the issue.

@iMichaela
Copy link
Contributor

5/2/2019

waiting for review from @david-waltermire-nist . We need to test the embedded Google analytics code.

@david-waltermire david-waltermire added this to the OSCAL 1.0 M1 milestone May 8, 2019
@david-waltermire david-waltermire added the Scope: Website Issues targeted at the OSCAL project website. label May 9, 2019
@brian-ruf
Copy link
Contributor

5/9/2019

Waiting on bug fix in #314, for acceptance of PR #326, and publication of the site to NIST pages.

@anweiss
Copy link
Contributor

anweiss commented May 9, 2019

Hey all ... sorry I wasn't on today's status call. Let me know when you're ready to queue up #326 for merging and I'll take it out of WIP status.

@david-waltermire
Copy link
Contributor

This has all been addressed in PR #326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Website Issues targeted at the OSCAL project website. User Story
Projects
None yet
Development

No branches or pull requests

5 participants