Skip to content

Commit f472a09

Browse files
committed
Merge branch '5.1' into 5.2
2 parents d43817e + ec79ef9 commit f472a09

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

.github/workflows/Build.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
strategy:
1616
fail-fast: false
1717
matrix:
18-
php_versions: ['8.1', '8.2', '8.3']
18+
php_versions: ['8.1', '8.2', '8.3', '8.4']
1919

2020
runs-on: ubuntu-latest
2121
name: PHPUnit - PHP ${{ matrix.php_versions }} - Memory SQLite
@@ -64,7 +64,7 @@ jobs:
6464
strategy:
6565
fail-fast: false
6666
matrix:
67-
php_versions: ['8.1', '8.2', '8.3']
67+
php_versions: ['8.1', '8.2', '8.3', '8.4']
6868

6969
runs-on: ubuntu-latest
7070
name: PHPUnit - PHP ${{ matrix.php_versions }} - MySQL
@@ -137,7 +137,7 @@ jobs:
137137
strategy:
138138
fail-fast: false
139139
matrix:
140-
php_versions: ['8.1', '8.2', '8.3']
140+
php_versions: ['8.1', '8.2', '8.3', '8.4']
141141

142142
runs-on: ubuntu-latest
143143
name: PHPUnit - PHP ${{ matrix.php_versions }} - MariaDB
@@ -203,7 +203,7 @@ jobs:
203203
strategy:
204204
fail-fast: false
205205
matrix:
206-
php_versions: ['8.1', '8.2', '8.3']
206+
php_versions: ['8.1', '8.2', '8.3', '8.4']
207207

208208
runs-on: ubuntu-latest
209209
name: PHPUnit - PHP ${{ matrix.php_versions }} - SQLite
@@ -259,7 +259,7 @@ jobs:
259259
strategy:
260260
fail-fast: false
261261
matrix:
262-
php_versions: ['8.1', '8.2', '8.3']
262+
php_versions: ['8.1', '8.2', '8.3', '8.4']
263263

264264
runs-on: ubuntu-latest
265265
name: PHPUnit - PHP ${{ matrix.php_versions }} - PostgreSQL
@@ -321,7 +321,7 @@ jobs:
321321
strategy:
322322
fail-fast: false
323323
matrix:
324-
php_versions: ['8.1', '8.2', '8.3']
324+
php_versions: ['8.1', '8.2', '8.3', '8.4']
325325

326326
runs-on: windows-latest
327327
name: PHPUnit - PHP ${{ matrix.php_versions }} - Windows

.github/workflows/PHPStan.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
php_versions: ['8.1', '8.2', '8.3']
16+
php_versions: ['8.1', '8.2', '8.3', '8.4']
1717

1818
runs-on: ubuntu-latest
1919
name: PHPStan - ${{ matrix.php_versions }}

app/src/Database/Relations/BelongsToManyThrough.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,12 @@ public function getExistenceCompareKey(): string
9494
/**
9595
* Add a "via" query to load the intermediate models through which the child models are related.
9696
*
97-
* @param string|null $viaRelationName
98-
* @param callable $viaCallback
97+
* @param string|null $viaRelationName
98+
* @param callable|null $viaCallback
9999
*
100100
* @return self
101101
*/
102-
public function withVia(?string $viaRelationName = null, callable $viaCallback = null): self
102+
public function withVia(?string $viaRelationName = null, ?callable $viaCallback = null): self
103103
{
104104
$this->tertiaryRelated = $this->intermediateRelation->getRelated();
105105

app/templates/pages/abstract/base.html.twig

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<meta http-equiv='Content-Type' content='text/html; charset=utf-8'>
88
<meta name="generator" content="UserFrosting" />
99
<meta name="description" content="{{ block('page_description')|e }}">
10+
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no">
1011
<meta name="author" content="{% block page_author %}{{ site.author }}{% endblock %}">
1112

1213
<title>{{ site.title }} | {% block page_title %}{% endblock %}</title>

0 commit comments

Comments
 (0)