Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): adjust gas estimation shown by the publish command #754

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

saeta-eth
Copy link
Contributor

This PR fixes a bug in the CLI's gas estimate for the publish command. The current implementation uses the estimateGas function with the wrong parameters, leading to the display of inaccurate gas estimations.

@saeta-eth saeta-eth requested a review from a team February 5, 2024 20:02
Copy link

changeset-bot bot commented Feb 5, 2024

⚠️ No Changeset found

Latest commit: 4ff6f47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Feb 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4ff6f47. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@saeta-eth saeta-eth merged commit c5cfba1 into main Feb 8, 2024
5 of 9 checks passed
@saeta-eth saeta-eth deleted the fix/publish-fee-shown branch February 8, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants