Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fee): Add package publication fee of 1 wei #425

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Conversation

mjlescano
Copy link
Member

@mjlescano mjlescano commented Sep 10, 2023

@nx-cloud
Copy link

nx-cloud bot commented Sep 10, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5f86f8e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot of other changes on this project besides the 1 wei fee. Also is there a function in the cannon registry for the owner to withdraw the ETH tokens?

@mjlescano
Copy link
Member Author

Lot of other changes on this project besides the 1 wei fee. Also is there a function in the cannon registry for the owner to withdraw the ETH tokens?

Yup, will actually split the PR to avoid confussions. And nope, going to add the withdraw.

@dbeal-eth dbeal-eth merged commit 26027a0 into main Sep 15, 2023
@dbeal-eth dbeal-eth deleted the add-publish-fee branch September 15, 2023 19:26
@FuzzB0t FuzzB0t linked an issue Sep 16, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry Upgrade
2 participants