fix(builder): Add preset reference in source/package name #415
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2390750. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
packages/builder/src/steps/import.ts
Outdated
| * If a preset reference is found in the package name by default it will take preference over a defined preset. | ||
| */ | ||
| if (cfg.source.includes('@')) { | ||
| cfg.preset = cfg.source.slice(cfg.source.indexOf('@') + 1); |
There was a problem hiding this comment.
if a user specsifies both a preset in the source and a preset in the config, its probably an error, one way or the other. shouldn't we warn them about this somehow?
packages/builder/src/steps/import.ts
Outdated
| * Checks for preset reference in source name, anything after the '@' references a preset. | ||
| * If a preset reference is found in the package name by default it will take preference over a defined preset. | ||
| */ | ||
| if (config.source.includes('@')) { |
There was a problem hiding this comment.
might make sense to turn the package name into a proper data structure at this point, rather than having this splitting/math happening all over the place
| /** | ||
| * Used to format any reference to a cannon package and split it into it's core parts | ||
| */ | ||
| export class PackageReference implements CannonPackageReference { |
There was a problem hiding this comment.
@dbeal-eth I added this package reference class and added it to provision and import steps for parsing out name, version and preset from package sources.
No description provided.