Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove anvil from inspect command and add support for target string #364

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

FuzzB0t
Copy link
Contributor

@FuzzB0t FuzzB0t commented Aug 25, 2023

No description provided.

@FuzzB0t FuzzB0t linked an issue Aug 25, 2023 that may be closed by this pull request
@nx-cloud
Copy link

nx-cloud bot commented Aug 25, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d3a6c17. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@FuzzB0t FuzzB0t self-assigned this Aug 26, 2023
@FuzzB0t FuzzB0t changed the title 363 inspect disable interactive mode in ci env fix(cli): remove anvil from inspect command Aug 26, 2023
@FuzzB0t FuzzB0t requested a review from dbeal-eth August 27, 2023 01:09
Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not match contents

PR appears to be making change to allow for target to be an array or non-array, but the title states somethign completely different which isnt included.

!!val.match(artifactNameRegex) ||
!!val.match(artifactPathRegex),
(val) => ({
message: `"${val}" must be a valid ethereum address, previously defined contract step name, contract artifact name or filepath`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously defined contract step name => existing contract step name

its not necessary that the contract step was "previous" (although it must be depended upon) (soon we are getting rid of depends so probably just best to keep response simple)

@FuzzB0t
Copy link
Contributor Author

FuzzB0t commented Aug 27, 2023

PR title does not match contents

PR appears to be making change to allow for target to be an array or non-array, but the title states somethign completely different which isnt included.

Yeah this PR contains both changes, although somewhat irrelevant to eachother, I'll change the PR title to match the contents better.

@FuzzB0t FuzzB0t changed the title fix(cli): remove anvil from inspect command fix: remove anvil from inspect command and add support for target string Aug 27, 2023
@FuzzB0t FuzzB0t merged commit 1dcaffb into main Aug 29, 2023
@FuzzB0t FuzzB0t deleted the 363-inspect-disable-interactive-mode-in-ci-env branch August 29, 2023 18:38
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inspect disable interactive mode in CI env
2 participants