Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): reduce the amount of checks that happen by default on chain definition #1573

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

dbeal-eth
Copy link
Contributor

prevents unnecessary errors in certain circumstances, paves the way for smart toml file language server features.

prevents unnecessary errors in certain circumstances, paves the way for
smart toml file language server features.
@dbeal-eth dbeal-eth added the bug Something isn't working label Dec 3, 2024
@dbeal-eth dbeal-eth self-assigned this Dec 3, 2024
Copy link

changeset-bot bot commented Dec 3, 2024

⚠️ No Changeset found

Latest commit: 0d5f1e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saeta-eth
Copy link
Contributor

I understand that this change is due to a bad implementation in a project. We should not remove the validations, but change their implementation to fit the validations that are being set up for some reason.

Copy link
Contributor

@saeta-eth saeta-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @dbeal-eth, I realized I was mistaken. Initially, I thought the validations had been removed, but they weren’t. Based on our conversation, I now understand that they only occur during the build process

@dbeal-eth dbeal-eth changed the base branch from dev to main December 8, 2024 19:27
@dbeal-eth dbeal-eth enabled auto-merge (squash) December 9, 2024 02:55
@dbeal-eth dbeal-eth disabled auto-merge December 9, 2024 02:55
@dbeal-eth dbeal-eth merged commit dc97a4f into main Dec 9, 2024
6 of 10 checks passed
@dbeal-eth dbeal-eth deleted the fix/definition-minimum-checks branch December 9, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants