-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): commandbar w new system #1551
Conversation
|
@@ -146,7 +146,7 @@ const SearchBar = () => { | |||
key={`${result.type}-${result.name}-${ | |||
'version' in result ? result.version : '' | |||
}`} | |||
value={`${result.type}-${result.name}`} | |||
value={`${result.type}-${result.name}-${Math.random()}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicosampler I think there's probably a better solution here? Iis it possible to use an index or something instead of a random number? I don't recall what 'value' is here, but we should check that clicking and keyboard navigation still work with the change.
CAN-615