Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): commandbar w new system #1551

Merged
merged 11 commits into from
Dec 27, 2024
Merged

feat(website): commandbar w new system #1551

merged 11 commits into from
Dec 27, 2024

Conversation

noahlitvin
Copy link
Member

CAN-615

Copy link

changeset-bot bot commented Nov 16, 2024

⚠️ No Changeset found

Latest commit: 78c3b64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented Nov 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/semver@7.5.8 None 0 23.3 kB types
npm/chalk@4.1.2 None +3 85.9 kB sindresorhus
npm/cors@2.8.5 None +1 25.5 kB dougwilson
npm/deepmerge@4.3.1 None 0 31.2 kB tehshrike
npm/fast-deep-equal@3.1.3 None 0 13 kB esp
npm/form-data@4.0.0 filesystem, network +5 314 kB niftylettuce
npm/lodash@4.17.21 None 0 1.41 MB bnjmnt4n
npm/prettier@2.8.8 environment, filesystem, unsafe 0 11.2 MB prettier-bot
npm/prompts@2.4.2 None +1 197 kB terkelg

🚮 Removed packages: npm/@iarna/toml@3.0.0, npm/@isaacs/ttlcache@1.4.1, npm/@isomorphic-git/lightning-fs@4.6.0, npm/@mdx-js/loader@3.1.0, npm/@mdx-js/react@3.1.0, npm/@monaco-editor/react@4.6.0, npm/@next/bundle-analyzer@14.2.6, npm/@next/mdx@15.0.3, npm/@next/third-parties@14.2.6, npm/@nomicfoundation/hardhat-toolbox@4.0.0, npm/@nomiclabs/hardhat-ethers@2.0.6, npm/@nomiclabs/hardhat-ethers@2.2.3, npm/@nomiclabs/hardhat-etherscan@3.1.8, npm/@radix-ui/react-accordion@1.2.1, npm/@radix-ui/react-aspect-ratio@1.1.0, npm/@radix-ui/react-checkbox@1.1.2, npm/@radix-ui/react-collapsible@1.1.1, npm/@radix-ui/react-dialog@1.1.2, npm/@radix-ui/react-dropdown-menu@2.1.2, npm/@radix-ui/react-icons@1.3.1, npm/@radix-ui/react-label@2.1.0, npm/@radix-ui/react-popover@1.1.2, npm/@radix-ui/react-scroll-area@1.2.1, npm/@radix-ui/react-separator@1.1.0, npm/@radix-ui/react-slot@1.1.0, npm/@radix-ui/react-tabs@1.1.1, npm/@radix-ui/react-toast@1.2.2, npm/@radix-ui/react-tooltip@1.1.3, npm/@rainbow-me/rainbowkit@2.1.5, npm/@rollup/plugin-json@6.1.0, npm/@rollup/plugin-node-resolve@15.2.3, npm/@rollup/plugin-terser@0.4.4, npm/@safe-global/api-kit@2.4.4, npm/@safe-global/protocol-kit@1.3.0, npm/@safe-global/safe-apps-sdk@9.1.0, npm/@sentry/nextjs@8.26.0

View full report↗︎

@@ -146,7 +146,7 @@ const SearchBar = () => {
key={`${result.type}-${result.name}-${
'version' in result ? result.version : ''
}`}
value={`${result.type}-${result.name}`}
value={`${result.type}-${result.name}-${Math.random()}`}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicosampler I think there's probably a better solution here? Iis it possible to use an index or something instead of a random number? I don't recall what 'value' is here, but we should check that clicking and keyboard navigation still work with the change.

@noahlitvin noahlitvin merged commit b1e4c0b into dev Dec 27, 2024
8 of 9 checks passed
@noahlitvin noahlitvin deleted the feat/command branch December 27, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants